Repository navigation
Broadcast pose transforms over spatial vector sequences - #310
Open
kaushikgunasekaren wants to merge 2 commits into
Open
kaushikgunasekaren wants to merge 2 commits into
kaushikgunasekaren wants to merge 2 commits into
Conversation
kaushikgunasekaren
requested review from
petercorke and
taughz
as code owners
November 17, 2026 17:49
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Transforming a sequence of spatial velocities, accelerations, forces or momenta fails with matrix-dimension errors. For example,
SE3(1, 2, 3) * SpatialVelocity(np.arange(12).reshape(6, 2))fails instead of transforming both vectors. Pose sequences also fail, and a six-vector sequence can accidentally be interpreted as one matrix rather than six spatial vectors.Fix
Use the existing binary-operation helper to broadcast singleton operands or pair equal-length sequences, applying the existing adjoint/coadjoint transform to each pair. Build the result with the same spatial-vector subclass and delegate SpatialForce to the shared implementation.
Validation
Singleton transform formulas are unchanged. In particular, this preserves the current finite-displacement interpretation of Twist3 multiplication; it does not decide #257's design question. This is separate from #299's copy-constructor and #301's row/column-input fixes. AI assistance was used for investigation, implementation and tests. Validated locally without robot hardware.