Repository navigation
Evaluate quaternion exponential sequences elementwise - #311
Open
kaushikgunasekaren wants to merge 2 commits into
Open
kaushikgunasekaren wants to merge 2 commits into
kaushikgunasekaren wants to merge 2 commits into
Conversation
Apply the existing scalar exponential to each stored quaternion, preserving tolerance and scalar return types.
Cover pure, non-pure, mixed, empty, tolerance-sensitive and stored-sign cases against scalar and analytic controls.
kaushikgunasekaren
requested review from
petercorke and
taughz
as code owners
November 18, 2026 17:35
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Quaternion.exp()passes sequence-valued scalar and vector properties to scalar math functions. A two-element sequence raisesTypeError, andq.log().exp()cannot round-trip a sequence.Change
Use the existing scalar implementation for each stored quaternion, forwarding
tol. Keep aUnitQuaternionresult when every scalar result is unit; mixed/non-unit results stayQuaternion. Empty input returns an emptyQuaternion. Singleton behavior is unchanged. Reading stored values directly avoids re-canonicalizing negative unit-quaternion signs before evaluation.Validation
tests/test_dualquaternion.py.AI assistance was used for investigation, implementation and tests. Validation is local Python testing only; no hardware validation is claimed.