Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
pathis absent. Valibot object-level checks emit these through Standard Schema;typeschemaResolvercurrently drops them, sotrigger()returnstrueandhandleSubmitcalls the success handler with{}for invalid input.path: []and the fixes in fix(valibot): report object-level issues on the empty path #893 and fix(arktype): report object-level issues on the empty path #895. Nonempty path conversion is unchanged. Usingerrors.rootinstead would not block submission because react-hook-form clears it before checking for errors.Reproduction against parent commit
e02dcd623ca915f35e5c418f5384f4732bafa925, using the built checkout with Valibot1.0.0-beta.12and react-hook-form7.83.0from its lockfile:bun run test typeschema/src/__tests__/typeschema.tsfails without the source fix and passes with it.bun lint,bun lint:types,bun run test(364 tests) andbun run buildpass. Also checked repeated validation, reset, sync/async providers,criteriaMode, raw/transformed output and packed CommonJS/ESM consumers.