Repository navigation
CameraRoll.getPhotos crashes trying to get iCloud photos #18159
Description
Issue Description
-
This happens when users have images stored in iCloud
-
This doesn't happen with images stored in the device.
-
For some users, CameraRoll.getPhotos is crashing for some specific files, the crash report doesn't display any information of the image, so it's difficult to find the issue.
-
This error doesn't happen to all users.
-
A similar issue has been reported before: iOS: Fix Crash when CameraRoll is getting assets from iCloud and no filename is provided. #13671 #17549 but this update wasn't included in react-native: 0.53.3 => 0.53.3
Anyway, I did this update manually, you can see it in the attached screenshot: https://github.com/facebook/react-native/pull/17549/files#diff-8aeecd9754b31530870848234a6a6386R202
And seems that this update fixed some cases, but not all of them, because the app is still crashing with some iCloud files.
Environment
Environment:
OS: macOS High Sierra 10.13.3
Node: 7.9.0
Yarn: 0.23.2
npm: 5.5.1
Watchman: 4.7.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 2.3 AI-162.4069837
Packages: (wanted => installed)
react: 16.2.0 => 16.2.0
react-native: 0.53.3 => 0.53.3
Expected Behavior
CameraRoll.getPhotos should return local and iCloud images
Actual Behavior
CameraRoll.getPhotos crashes trying to get iCloud photos
Steps to Reproduce
This error happens to some users only.
Happens only with iCloud Photos
Use the expo app to load your icloud photos. The crash could happen with a random image.
Expo App:
https://exp.host/@facuescobar/camera-roll-photos-2018
Code:
https://github.com/facuescobar/camera-roll-photos
CameraRoll.getPhotos params:
https://github.com/facuescobar/camera-roll-photos/blob/master/src/reducers/camera-roll.js#L20
CameraRoll.getPhotos call:
https://github.com/facuescobar/camera-roll-photos/blob/master/src/actions/camera-roll.js#L20
https://github.com/facuescobar/camera-roll-photos/blob/master/src/actions/camera-roll.js#L46
Crash Report
Activity
[-]CameraRoll.getPhotos crash trying to get iCloud photos[/-][+]CameraRoll.getPhotos crashes trying to get iCloud photos[/+]react-native-bot commentedon Mar 5, 2018
Thanks for posting this! It looks like your issue may refer to an older version of React Native. Can you reproduce the issue on the latest stable release?
Thank you for your contributions.
How to Contribute • What to Expect from Maintainers
facuescobar commentedon Mar 9, 2018
@react-native-bot I've upgraded to latest version and this issue has not been fixed there's also different times that Camera Roll can not obtain iCloud photos (syncing issue?) and it displays an empty list.
Can anyone take a look to this issue please?
facuescobar commentedon Mar 22, 2018
Any update here?
stale commentedon Jun 20, 2018
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.
react-native-bot commentedon Jul 17, 2018
I am closing this issue because it does not appear to have been verified on the latest release, and there has been no followup in a while.
If you found this thread after encountering the same issue in the latest release, please feel free to create a new issue with up-to-date information by clicking here.