Repository navigation
Closed
Labels
Good first issueInterested in collaborating? Take a stab at fixing one of these issues.Interested in collaborating? Take a stab at fixing one of these issues.Help Wanted
Issues ideal for external contributors.Issues ideal for external contributors.Platform: iOSiOS applications.iOS applications.Resolution: LockedThis issue was locked by the bot.This issue was locked by the bot.
Description
There seems to be a bug with ActivityIndicatorIOS in the latest stable release.
- Set
animating={false}dynamically works as expected (ActivityIndicatorIOS is hidden) - Set
animation={false}as initial prop won't hide it.
Reproduce
I assume that HMR is enabled for steps 3-5. Otherwise just use the template below.
- Fresh project: react-native init helloWorld
- Add
<ActivityIndicatorIOS animating={false} />toindex.ios.js - Run the simulator, e.g. via
react-native run-ios--> Is shown and not animated - Change prop to
<ActivityIndicatorIOS animating={true} />--> Is shown and animated - Change prop back to
<ActivityIndicatorIOS animating={false} />--> Is hidden as it should
Template
...
import {
AppRegistry,
ActivityIndicatorIOS,
StyleSheet,
Text,
TouchableOpacity,
View,
} from 'react-native';
...
class helloWorld extends Component {
constructor(props) {
super(props);
this.state = {
animateActivityIndicatorIOS: false,
}
}
render() {
return (
<View style={styles.container}>
<TouchableOpacity onPress={() => this.setState({animateActivityIndicatorIOS: !this.state.animateActivityIndicatorIOS})}>
<Text>Toggle ActivityIndicatorIOS</Text>
</TouchableOpacity>
<Text>{'\n'}This ActivityIndicatorIOS should be shown initially, although animating=false:{'\n'}</Text>
<ActivityIndicatorIOS animating={this.state.animateActivityIndicatorIOS} />
</View>
);
}
}Reacted by Hugo Dozois and Akshay S Murthy
Metadata
Metadata
Assignees
Labels
Good first issueInterested in collaborating? Take a stab at fixing one of these issues.Interested in collaborating? Take a stab at fixing one of these issues.Help Wanted
Issues ideal for external contributors.Issues ideal for external contributors.Platform: iOSiOS applications.iOS applications.Resolution: LockedThis issue was locked by the bot.This issue was locked by the bot.
Activity
charpeni commentedon Jun 7, 2016
cc @janicduplessis
Seems related to #7976.
janicduplessis commentedon Jun 13, 2016
It seems like calling
UIActivityIndicator.stopAnimatingdoesn't work before the view has been layed out. I had a similar issue withRefreshControland what I ended up doing is calling it in the first call youlayoutSubviews. If someone wants to submit a PR to fix this it would be great as I'm pretty busy at the moment :)Fixes ActivityIndicatorIOS doesn't hide initially
Fixes ActivityIndicatorIOS doesn't hide initially
timjacobi commentedon Jul 15, 2016
Can this be closed?