Skip to content

RCTAsyncStorage.getAllKey callback does not happen RN 0.31 Android 4.2.2 when debugging #9319

Closed

Description

@eranbes

Android 4.2.2
RN 0.31

RCTAsyncStorage.getAllKeys(function(error, keys) { line in AsyncStorage.js, getAllKeys method never gets to callback when debugging in chrome.
Also, AsyncStorage.js chooses to use sqlite implementation (at least in the chrome debugger).

This issue happen only in debug.

Activity

  1. corbt commented on Aug 11, 2016

    @corbt
    Contributor

    I have replicated this issue on 0.31 and 0.32.0-rc.0.

    I can confirm that AsyncStorage.getAllKeys works while running on the device normally, but not when debugging JS remotely in Chrome.

    EDIT: Replicated on Android 6.0.1 with a Oneplus One and Nexus 9, so don't think it's related to your version of Android.

  2. alenia commented on Aug 12, 2016

    @alenia

    I'm also experiencing this issue. It means I haven't been able to use the chrome debugger since upgrading to 0.31. Anyone have any workarounds for now?

  3. corbt commented on Aug 12, 2016

    @corbt
    Contributor

    @alenia nope, still broken for me. Haven't had a chance to investigate.

  4. kageurufu commented on Aug 12, 2016

    @kageurufu
    Contributor

    I have the same issue, it works as expected in 0.30.

    I have downgraded until the cause is determined. I have tested on a Nexus 5 a 6.0.1, and a Nexus 6P at N preview 5

  5. rigdern commented on Aug 16, 2016

    @rigdern
    Contributor

    I hit this as well in 0.32.0-rc. I suspect that the commit in 0.31.0 (c89c25f) which makes the new bridge the default bridge introduced the issue.

  6. rigdern commented on Aug 17, 2016

    @rigdern
    Contributor

    @cjhopman, do you have any thoughts on this issue. Do you think my theory about your commit (c89c25f) is accurate?

  7. kageurufu commented on Aug 17, 2016

    @kageurufu
    Contributor

    @rigdern the bridge is definitely the issue. I modified my MainApplication to call setUseOldBridge(true) in the ReactNativeHost subclass, and I'm now able to use AsyncStorage while debugging on Android with 0.31.0

    I don't have the time to debug this issue fully beyond that, but for those experiencing this issue, I posted a workaround: https://gist.github.com/kageurufu/79e4aaa1c41cbdb147e936d7e473029d

  8. mkonicek commented on Aug 20, 2016

    @mkonicek
    Contributor

    @rigdern Thanks for looking into it! I'll ping @cjhopman and @mhorowitz on fb@work messenger.

  9. changed the title [-]RCTAsyncStorage.getAllKey callback does not happen RN 0.31 Android 4.2.2[/-] [+]RCTAsyncStorage.getAllKey callback does not happen RN 0.31 Android 4.2.2 when debugging[/+] on Aug 20, 2016
  10. lexs commented on Aug 23, 2016

    @lexs
    Contributor

    Closing in favor of #9436

  11. locked as resolved and limited conversation to collaborators on May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions