Skip to content
This repository was archived by the owner on Nov 19, 2026. It is now read-only.
This repository was archived by the owner on Nov 19, 2026. It is now read-only.

Passing in multiple files does not work #167

Open

Description

@concaf

OpenCompose CLI barfs when multiple files are provided.

$ opencompose convert -f examples/hello-nginx-external.yaml -f examples/hello-nginx.yaml 

ERROR: unable to read file 'examples/hello-nginx-external.yaml,examples/hello-nginx.yaml': open examples/hello-nginx-external.yaml,examples/hello-nginx.yaml: no such file or directory
$ opencompose convert -f examples/hello-nginx-external.yaml,examples/hello-nginx.yaml 

ERROR: unable to read file 'examples/hello-nginx-external.yaml,examples/hello-nginx.yaml': open examples/hello-nginx-external.yaml,examples/hello-nginx.yaml: no such file or directory

Neither of the above cases work.

Activity

  1. self-assigned this
    on Jun 12, 2017
  2. added a commit that references this issue on Jun 13, 2017
    1b3f6ad
  3. concaf commented on Jun 13, 2017

    @concaf
    CollaboratorAuthor

    Update:

    • The first problem is that our vendored viper is pretty old, and hence multiple files are not even getting parsed. This is being fixed by updated the vendor directory.

    But there is more to this problem, merging different object.OpenCompose structs has not been implemented yet https://github.com/redhat-developer/opencompose/blob/master/pkg/cmd/convert.go#L106, and currently, only the input from the first file passed is taken into account.

    We are assuming that all the files being passed are a part of one application written in OpenCompose and we will be merging them.

    • We should log each time an override is done
    • We should document this behavior, since this includes overriding fields and hence loss of some information

    CC: @kadel

  4. removed their assignment
    on May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions