Repository navigation
Reveal the edited file after applying a code action - #4566
Open
robstryker wants to merge 1 commit into
Open
robstryker wants to merge 1 commit into
robstryker wants to merge 1 commit into
Conversation
When a quick fix edits a document other than the active one (e.g. "Create method 'call()' in type 'Foo'"), VS Code applies the edit but leaves the active editor alone. Attach a java.reveal.edit command to code actions that carry an edit so the changed file is shown and the first change is revealed. The target is taken from the raw LSP edit since WorkspaceEdit.entries() does not include snippet edits, and any command the action already has is run first. Also move revealWorkspaceEdit next to applyWorkspaceEdit, make it open the document with showTextDocument instead of revealing in whichever editor is active, and use it for java.apply.workspaceEdit. Fixes redhat-developer#765 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Rob Stryker <rob@oxbeef.net>
Contributor
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a quick fix edits a document other than the active one (e.g. "Create method 'call()' in type 'Foo'"), VS Code applies the edit but leaves the active editor alone. Attach a java.reveal.edit command to code actions that carry an edit so the changed file is shown and the first change is revealed. The target is taken from the raw LSP edit since WorkspaceEdit.entries() does not include snippet edits, and any command the action already has is run first.
Also move revealWorkspaceEdit next to applyWorkspaceEdit, make it open the document with showTextDocument instead of revealing in whichever editor is active, and use it for java.apply.workspaceEdit.
Method revealWorkspaceEdit was moved between files to avoid a circular dependency.
Fixes #765