Skip to content

rustup can't update nightly #51699

Closed
Closed
rustup can't update nightly#51699
Labels
T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.

Description

@durka
durka
opened on Jun 22, 2018

There seems to be a malformed URL in the rustup manifest since 1.27 got released today.

durska:rust alex$ rustup self update
info: checking for self-updates
durska:rust alex$ rustup update
info: syncing channel updates for 'stable-x86_64-apple-darwin'
info: syncing channel updates for 'beta-x86_64-apple-darwin'
info: syncing channel updates for 'nightly-x86_64-apple-darwin'
info: latest update on 2018-06-22, rust version 1.28.0-nightly (662c70a59 2018-06-21)
info: downloading component 'rustc'
error: failed to parse url: 1.28.0-nightly (662c70a59 2018-06-21)/2018-06-22/rustc-nightly-x86_64-apple-darwin.tar.xz
info: checking for self-updates

       stable-x86_64-apple-darwin unchanged - rustc 1.27.0 (3eda71b00 2018-06-19)
         beta-x86_64-apple-darwin unchanged - rustc 1.28.0-beta.1 (8e6052e77 2018-06-21)
  nightly-x86_64-apple-darwin update failed - rustc 1.28.0-nightly (990d8aa74 2018-05-25)

durska:rust alex$

Activity

  1. ishitatsuyuki commented on Jun 22, 2018

    @ishitatsuyuki
    ishitatsuyuki
    on Jun 22, 2018
    Contributor

    Related to #51680?

  2. nrc commented on Jun 22, 2018

    @nrc
    nrc
    on Jun 22, 2018
    Member

    This is causing problems on Travis too, see for example rustfmt

  3. nrc
    added
    I-nominated
    T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.
    T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.
    on Jun 22, 2018

  4. Havvy commented on Jun 22, 2018

    @Havvy
    Havvy
    on Jun 22, 2018
    Contributor

    This affects the mozilla overlay for nixpkgs as well, since that uses the same URLs.

  5. mati865 commented on Jun 22, 2018

    @mati865
    mati865
    on Jun 22, 2018
    Member

    Comparison of nightly and stable metadata for rustup:

    # channel-rust-nightly.toml
[pkg.cargo.target.x86_64-unknown-linux-gnu]
available = true
url = "1.28.0-nightly (662c70a59 2018-06-21)/2018-06-22/cargo-nightly-x86_64-unknown-linux-gnu.tar.gz"
hash = "039fc11d15fab9951061ee25991708659f6a3900d58fcd0a3db9e6f8b4987d51"
xz_url = "1.28.0-nightly (662c70a59 2018-06-21)/2018-06-22/cargo-nightly-x86_64-unknown-linux-gnu.tar.xz"
xz_hash = "27613570b55d12e7f3b66cf5296a41c8d7a8ee1c95cce7f9cfedee3f201b1e11"

# channel-rust-stable.toml
[pkg.cargo.target.x86_64-unknown-linux-gnu]
available = true
url = "https://static.rust-lang.org/dist/2018-06-21/cargo-0.28.0-x86_64-unknown-linux-gnu.tar.gz"
hash = "3612ae45bf4504836810a74e6cef177358fce7219794013536c354bbd6ee61ef"
xz_url = "https://static.rust-lang.org/dist/2018-06-21/cargo-0.28.0-x86_64-unknown-linux-gnu.tar.xz"
xz_hash = "386ba6e3c0a2b1718fe0487d03f96e1ad12796cfb44813dfc22c5be54657e7a4"

    Somehow https://static.rust-lang.org/dist got replaced by 1.28.0-nightly (662c70a59 2018-06-21) for latest nightly, other things seem fine.
    Opening https://static.rust-lang.org/dist/2018-06-22/cargo-nightly-x86_64-unknown-linux-gnu.tar.gz in the browser starts downloading of the archive.

  6. kennytm
    added
    regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.
    on Jun 22, 2018

  7. kennytm commented on Jun 22, 2018

    @kennytm
    kennytm
    on Jun 22, 2018
    Member

    Regression caused by #50336.

    diff --git a/src/bootstrap/dist.rs b/src/bootstrap/dist.rs
index 9092deeac461..73cda4b436d4 100644
--- a/src/bootstrap/dist.rs
+++ b/src/bootstrap/dist.rs
@@ -1756,6 +1740,7 @@ impl Step for HashSign {
         cmd.arg(builder.package_vers(&builder.release_num("cargo")));
         cmd.arg(builder.package_vers(&builder.release_num("rls")));
         cmd.arg(builder.package_vers(&builder.release_num("rustfmt")));
+        cmd.arg(builder.llvm_tools_vers());
         cmd.arg(addr);
 
         builder.create_dir(&distdir(builder));
  8. kennytm
    added a commit that references this issue on Jun 22, 2018

    Recognize the extra "LLVM tools versions" argument to build-manifest.

    07ad6e0

  9. mati865 commented on Jun 22, 2018

    @mati865
    mati865
    on Jun 22, 2018
    Member

    @kennytm you were few minutes faster.
    build-manifest tool doesn't expect additional argument:

    rust/src/tools/build-manifest/src/main.rs

    Lines 178 to 179 in 8d22af8

    let rls_release = args.next().unwrap();
    let s3_address = args.next().unwrap();

    Btw rustfmt arg isn't there as well 😕 Forget about it, old commit

  10. kennytm commented on Jun 22, 2018

    @kennytm
    kennytm
    on Jun 22, 2018
    Member

    @mati865 You're looking at an old commit 😄

    rust/src/tools/build-manifest/src/main.rs

    Lines 213 to 215 in 4b17d31

    let rls_release = args.next().unwrap();
    let rustfmt_release = args.next().unwrap();
    let s3_address = args.next().unwrap();

  11. mati865 commented on Jun 22, 2018

    @mati865
    mati865
    on Jun 22, 2018
    Member

    @kennytm Oops, commit from 27 Jul 2017.
    Probably I should've had a bit more sleep 😒

  12. kennytm
    added a commit that references this issue on Jun 22, 2018

    Rollup merge of rust-lang#51703 - kennytm:fix-51699, r=nrc

    d41cb99

  13. wesbz commented on Jun 22, 2018

    @wesbz
    wesbz
    on Jun 22, 2018

    Updating with a previous version such as rustup update nightly-2018-06-18 seems to work for me...

  14. 4 remaining items

  15. mykmelez
    added a commit that references this issue on Jun 22, 2018

    use specific rustfmt nightly (#51)

    d2633d6
  16. bors
    closed this as completedin #51703on Jun 22, 2018

  17. est31 commented on Jun 22, 2018

    @est31
    est31
    on Jun 22, 2018
    Member

    For anyone wondering, PR #51703 has fixed the bug. It will take until the next scheduled nightly upload until rustup starts working again.

  18. durka commented on Jun 22, 2018

    @durka
    durka
    on Jun 22, 2018
    ContributorAuthor

    Should rustup tests be added as part of the release process?

  19. emilyalbini commented on Jun 22, 2018

    @emilyalbini
    emilyalbini
    on Jun 22, 2018
    Member

    There is already an open issue about testing rustup. rust-lang/rust-central-station#17

  20. slaiyer commented on Jun 23, 2018

    @slaiyer
    slaiyer
    on Jun 23, 2018

    @est31 when is the next scheduled nightly upload?

  21. SimonSapin commented on Jun 23, 2018

    @SimonSapin
    SimonSapin
    on Jun 23, 2018
    Contributor

    @slaiyer It should be in progress right now. https://github.com/rust-lang/rust-central-station/blob/12b28bc1c2/crontab#L7 runs at midnight UTC.

  22. ZhangHanDong commented on Jun 23, 2018

    @ZhangHanDong
    ZhangHanDong
    on Jun 23, 2018
    ✗ rustup update nightly
info: syncing channel updates for 'nightly-x86_64-apple-darwin'
info: latest update on 2018-06-22, rust version 1.28.0-nightly (662c70a59 2018-06-21)
info: downloading component 'rustc'
error: failed to parse url: 1.28.0-nightly (662c70a59 2018-06-21)/2018-06-22/rustc-nightly-x86_64-apple-darwin.tar.xz
info: caused by: relative URL without a base

  23. Mark-Simulacrum commented on Jun 23, 2018

    @Mark-Simulacrum
    Mark-Simulacrum
    on Jun 23, 2018
    Member

    Nightly should release within the next 30 minutes, probably the next 10-15 minutes. Until then, yes, the command won't work.

  24. kazcw commented on Jun 23, 2018

    @kazcw
    kazcw
    on Jun 23, 2018
    Contributor

    2018-06-23 is live and the url is fixed

  25. tbu-
    added a commit that references this issue on Jun 23, 2018

    chore: Update pinned nightly so compiling works again

    9f183d2
  26. kbknapp
    added a commit that references this issue on Jun 27, 2018

    chore: Update pinned nightly so compiling works again

    4b5ba7d
  27. Mark-Simulacrum
    removed
    I-nominated
    on Jun 27, 2018

  28. grossws commented on Jan 10, 2019

    @grossws
    grossws
    on Jan 10, 2019

    Same issue with current meta for nightly:

    error: failed to parse url: nightly/2019-01-10/rustc-nightly-x86_64-unknown-linux-gnu.tar.xz
info: caused by: relative URL without a base

    From https://static.rust-lang.org/dist/channel-rust-nightly.toml:

    manifest-version = "2"
date = "2019-01-10"

[pkg.rustc.target.x86_64-unknown-linux-gnu]
available = true
url = "nightly/2019-01-10/rustc-nightly-x86_64-unknown-linux-gnu.tar.gz"
hash = "f4b5c77ce75ffdee97d460f03b8f84dd49129143c8e896e44d4512de2c0a686a"
xz_url = "nightly/2019-01-10/rustc-nightly-x86_64-unknown-linux-gnu.tar.xz"
xz_hash = "54a1b1791612651ded4c052c2c29a9b2e681344da4cebdc2382d14b62936f4fa"

  29. kennytm commented on Jan 10, 2019

    @kennytm
    kennytm
    on Jan 10, 2019
    Member

    @grossws Please reply to the stickied issue #57488, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions