Repository navigation
fix(component): normalize path separators - #4179
Merged
Merged
Conversation
rami3l
force-pushed
the
fix/win-path-from-slash2
branch
from
February 10, 2025 05:40
13934ae to
c412a54
Compare
ComponentPart::(en|de)code()
rami3l
force-pushed
the
fix/win-path-from-slash2
branch
3 times, most recently
from
February 10, 2025 13:30
c6ebbfc to
6908f50
Compare
rami3l
marked this pull request as ready for review
February 10, 2025 14:22
ChrisDenton
reviewed
Feb 10, 2025
ChrisDenton
approved these changes
Feb 11, 2025
ChrisDenton
left a comment
Member
There was a problem hiding this comment.
Thanks! I think this will be more consistent between platforms.
rami3l
added this pull request to the merge queue
Feb 11, 2025
djc
reviewed
Feb 11, 2025
rami3l
removed this pull request from the merge queue due to a manual request
Feb 11, 2025
djc
approved these changes
Feb 11, 2025
rami3l
enabled auto-merge
February 11, 2025 09:45
rami3l
disabled auto-merge
February 11, 2025 09:46
…de)code()` Co-authored-by: rhysd <lin90162@yahoo.co.jp>
rami3l
force-pushed
the
fix/win-path-from-slash2
branch
from
February 11, 2025 09:49
cc248fe to
4d8cf37
Compare
rami3l
enabled auto-merge
February 11, 2025 09:52
rami3l
added this pull request to the merge queue
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #3077.
This solution is based on the analysis made in #3077 (comment).
PS: Sincerely, I think thisComponentPartneeds to be changed to something like:... I'd like to work on stylistic changes like this once I'm done with updating the test cases (some of them are of course expected to break).Done.