Skip to content

fix(component): normalize path separators - #4179

Merged
rami3l merged 6 commits into
rust-lang:masterfrom
rami3l:fix/win-path-from-slash2
Feb 11, 2025
Merged

rami3l merged 6 commits into
rust-lang:masterfrom
rami3l:fix/win-path-from-slash2

Conversation

@rami3l

@rami3l rami3l commented Feb 9, 2025 •

Copy link
Copy Markdown
Member

Supersedes #3077.

This solution is based on the analysis made in #3077 (comment).

PS: Sincerely, I think this ComponentPart needs to be changed to something like:

struct ComponentPart {
  pub kind: String,
  pub path: PathBuf,
}

... I'd like to work on stylistic changes like this once I'm done with updating the test cases (some of them are of course expected to break).
Done.

@rami3l
rami3l force-pushed the fix/win-path-from-slash2 branch from 13934ae to c412a54 Compare February 10, 2025 05:40
@rami3l rami3l changed the title fix(component): normalize path separators during ComponentPart::(en|de)code() fix(component): normalize path separators Feb 10, 2025
@rami3l
rami3l force-pushed the fix/win-path-from-slash2 branch 3 times, most recently from c6ebbfc to 6908f50 Compare February 10, 2025 13:30
@rami3l
rami3l requested a review from djc February 10, 2025 14:22
@rami3l
rami3l marked this pull request as ready for review February 10, 2025 14:22
Comment thread src/dist/component/components.rs Outdated
Comment thread src/dist/prefix.rs
@rami3l
rami3l requested a review from ChrisDenton February 11, 2025 04:09
@rami3l rami3l added this to the 1.28.0 milestone Feb 11, 2025

@ChrisDenton ChrisDenton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this will be more consistent between platforms.

@rami3l
rami3l added this pull request to the merge queue Feb 11, 2025
Comment thread src/dist/component/components.rs Outdated
@rami3l
rami3l removed this pull request from the merge queue due to a manual request Feb 11, 2025
@rami3l
rami3l requested a review from djc February 11, 2025 09:40
@rami3l
rami3l enabled auto-merge February 11, 2025 09:45
@rami3l
rami3l disabled auto-merge February 11, 2025 09:46
@rami3l
rami3l force-pushed the fix/win-path-from-slash2 branch from cc248fe to 4d8cf37 Compare February 11, 2025 09:49
@rami3l
rami3l enabled auto-merge February 11, 2025 09:52
@rami3l
rami3l added this pull request to the merge queue Feb 11, 2025
Merged via the queue into rust-lang:master with commit a2d5350 Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants