Repository navigation
Move ChaChaRng and Hc128Rng to their own crates - #607
Merged
Merged
Conversation
Contributor
Author
|
This fixes #431 (only what is said in the title, not the whole list in the issue). |
Member
Member
Contributor
Author
|
I'll have a look, but presumably not before next week, when I'm back from
vacation.
…On Thu, Sep 20, 2018, 10:30 Diggory Hardy ***@***.***> wrote:
Okay @vks <https://github.com/vks> could you please update in line with
#611 <#611>? In particular, the
authors line (ChaCha should list both; Hc128 can just list the Rand
project devs). Also, the LICENSE-MIT files.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#607 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AACCtAdm0fJfTtXcfUl-ahDj4-qD-ah8ks5uc1IMgaJpZM4WpPPO>
.
|
Contributor
Author
|
@dhardy I think I addressed all your concerns. I'll squash after review. |
dhardy
reviewed
Sep 25, 2018
Contributor
Author
|
I don't know what is going on with those MIPS and ARMv7 failures. The rest should be fine now. |
Member
|
Me neither. On both runners the ChaCha crate passes but the HC128 one fails. There's very little difference between the Cargo.toml or lib files; the only significant thing I see is a build script for ChaCha. You can just comment out the hc128 cross-tests and merge if you like; everything else looks good. |
They fail to link for unknown reasons. Also see rust-random#607.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This leaves
rand::prngas a module only containing deprecated code. In principle it could be removed/hidden, but we still want to have the PRNG comparison somewhere.