Repository navigation
Make Bernoulli::new return a Result - #803
Merged
Merged
Conversation
Contributor
Author
|
I'm not sure whether a breaking change makes sense while deprecating (instead of removing) the other panicking distributions. |
dhardy
approved these changes
May 23, 2019
dhardy
left a comment
dhardy
left a comment
Member
There was a problem hiding this comment.
Thanks. As you said before, I don't think this constructor gets called directly too often. We are allowed to make breaking changes in minor releases, and I think this one is worth doing.
I believe it's ready for merging?
Contributor
Author
|
Yeah, I also think this is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #799.