Skip to content

Remove #![feature(alloc)] - #856

Merged
dhardy merged 2 commits into
rust-random:masterfrom
taiki-e:alloc
Aug 23, 2019
Merged

dhardy merged 2 commits into
rust-random:masterfrom
taiki-e:alloc

Conversation

@taiki-e

@taiki-e taiki-e commented Aug 5, 2019

Copy link
Copy Markdown
Contributor

The alloc crate has been stabilized in 1.36.

@dhardy

dhardy commented Aug 6, 2019

Copy link
Copy Markdown
Member

Thanks for the PR.

AFAICT this is not a breaking change (except for old nightlies), but will enable support for Rust ≥ 1.36.

Could you please:

  1. Add a note to the MSRV (1.32) testers about this exception
  2. Update the README
  3. Add a note in the CHANGELOG

@RalfJung

RalfJung commented Aug 8, 2019

Copy link
Copy Markdown
Contributor

The Miri component has been updated, so that part of CI should work again now.

@dhardy

dhardy commented Aug 8, 2019

Copy link
Copy Markdown
Member

Thanks, I restarted it. But both failures are unrelated to this PR so not worried about them here.

@dhardy

dhardy commented Aug 22, 2019

Copy link
Copy Markdown
Member

@taiki-e any chance you could make the additions I requested?

@taiki-e

taiki-e commented Aug 22, 2019

Copy link
Copy Markdown
Contributor Author

@dhardy Sorry for the delay in replying. addressed in 918765d.

@dhardy

dhardy commented Aug 23, 2019

Copy link
Copy Markdown
Member

Thanks; LGTM

@dhardy
dhardy merged commit a4cd495 into rust-random:master Aug 23, 2019
@taiki-e
taiki-e deleted the alloc branch August 23, 2019 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants