Repository navigation
chore(node): pin Node 24.22.1 and make AGENTS.md the single agent guide - #102
Merged
Merged
Conversation
Pin every CI, release and Pages job to exact Node 24.22.1. They pinned 22.22.3 before, except verify-version-sync and the Pages build, which were still on Node 20 (end of life since 2026-04-30). deploy.ps1 and release-package-contract.mjs now require exact v24.22.1, and their tests follow. AGENTS.md is now the only instruction file. CLAUDE.md is cut down to `@AGENTS.md` so Claude Code still loads it. Restore the code-block comments that the earlier consolidation (12d4edc) overwrote with the file title. The published v22 engine range (^22.22.3 || ^24.15.0 || ^26.0.0) and past release records stay as they are. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sdcorejs
pushed a commit
that referenced
this pull request
Oct 23, 2026
Brings in the Node 24.22.1 pin and the single AGENTS.md guide (#102). SYNC-STATUS.md conflicted only on the Updated At timestamp of both syncs; resolved by running npm run sync again on the merged tree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The repo pinned exact Node
22.22.3for every install, build and release step. Node 22 has been in maintenance since 2025-10-21 and reaches end of life on 2027-04-30. Two jobs (verify-version-syncinci.ymland the Pages build) were still on Node 20, which reached end of life on 2026-04-30. This PR moves the whole repo to exact Node24.22.1, the current Node 24 LTS release. Node 24 is supported until 2028-04-30.The agent instructions also lived in two near-identical files:
CLAUDE.mdandAGENTS.md, 330 and 342 lines.AGENTS.mdhad drifted. The consolidation in 12d4edc had overwritten the step comments in its code blocks with the file title (# sdcorejs-angular - Agent Instructions).What changed
Node 24.22.1
ci.yml(5 jobs),publish-npm.yml(6 jobs) anddeploy-pages.yml(1 job) now usenode-version: '24.22.1'.scripts/deploy.ps1andscripts/release-package-contract.mjsnow require exactv24.22.1.release-package-contract.test.mjsandpublish-npm-workflow.test.mjsassert the new pin.README.md,AGENTS.mdand the workspace READMEs are updated. The workspace READMEs were edited inversions/v19and rolled out withnpm run sync. The onlySYNC-STATUS.mdchange is the timestamp.Single agent guide
AGENTS.mdis the only instruction file. A note at the top says so, and the "Instruction provenance" section is removed.CLAUDE.mdnow contains only@AGENTS.md. Claude Code auto-loadsCLAUDE.mdbut notAGENTS.md, so the import keeps the rules loaded.CLAUDE.md.HANDOFF.md,.gitignoreanddeploy-pages.ymlnow point toAGENTS.md.Unchanged on purpose
^22.22.3 || ^24.15.0 || ^26.0.0is a consumer contract, and it already includes 24.22.1.scripts/release-contracts/*,.sdcorejs/**andCHANGELOG.md. They describe how past releases were built.npm@11.5.1.Verification
All of these ran locally on Node
v24.22.1/ npm11.19.1(Windows) and exited 0:npm ci(root) andnpm --prefix versions/v19 ci --legacy-peer-depsnpm run check:sync: v20, v21 and v22 match v19npm run test:scripts: 270 tests, 0 failuresnpm run check:scss-hexnpx ng build sdcorejs-angularinversions/v19npm --prefix versions/v22 ci(clean install policy)Not run locally, left to CI: the full v19 Karma suite with coverage, v20/v21 installs and builds, the Showcase and e2e.
Note for reviewers
npm 11.19 (bundled with Node 24.22.1) skips install scripts that are not approved under
allowScripts. For this repo that means esbuild, lmdb, msgpackr-extract and @parcel/watcher. Each install printsnpm warn install-scripts. These packages load prebuilt binaries from their optional platform dependencies, so the v19 library build passes. If a CI job fails on one of them, approve it withnpm install-scripts approve <pkg>rather than switching back to Node 22.🤖 Generated with Claude Code