Repository navigation
fix(s08): recognize Anthropic prompt overflow errors - #561
Merged
Merged
Conversation
Recognize the documented prompt is too long message in the bounded reactive-compaction path. Synchronize all three chapter READMEs and add regression coverage for recovery, compatible markers, retry exhaustion, and unrelated errors. Validation: 21 targeted tests and 22 subtests passed. Full suite: 486 passed, 1 pre-existing S16 scenario ordering failure, 100 subtests passed. Refs shareAI-lab#560. Prepared with AI assistance.
CrazyBoyM
approved these changes
Oct 27, 2026
CrazyBoyM
left a comment
Contributor
There was a problem hiding this comment.
The added prompt is too long predicate preserves the existing error markers and one-retry limit. The three READMEs agree. Context-compaction/tool-pair tests: 21 passed, 22 subtests passed, with a fake model client and no paid API calls. Prefer this tested implementation over duplicate #565.
AI-assisted maintainer review. Vercel statuses point to the account-blocked deployment notice, not a passing deploy. Combined local verification with resolved test/generated-data overlaps: 498 tests and 112 subtests passed.
CrazyBoyM
added a commit
that referenced
this pull request
Oct 27, 2026
ruohai0925
pushed a commit
to ruohai0925/learn-claude-code
that referenced
this pull request
Nov 17, 2026
Recognize the documented prompt is too long message in the bounded reactive-compaction path. Synchronize all three chapter READMEs and add regression coverage for recovery, compatible markers, retry exhaustion, and unrelated errors. Validation: 21 targeted tests and 22 subtests passed. Full suite: 486 passed, 1 pre-existing S16 scenario ordering failure, 100 subtests passed. Refs shareAI-lab#560. Prepared with AI assistance.
ruohai0925
pushed a commit
to ruohai0925/learn-claude-code
that referenced
this pull request
Nov 17, 2026
…eAI-lab#603) Incorporate shareAI-lab#578, preserve shareAI-lab#561's regression tests, and distinguish a complete request from a prefix of an older request. EN/ZH/JA examples stay synchronized. Co-authored-by: ship <shiyipeng2002@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S08 now recognizes Anthropic's
prompt is too longerror and uses its existing reactive-compaction path to retry once. Previously that message bypassed recovery and propagated immediately. The change preserves the existing error markers and retry limit, synchronizes the three chapter READMEs, and adds five regression cases.Fixes #560
Validation:
test_s16_scenario_matches_the_deterministic_runtime, also reproduced on unmodified upstream main.git diff --checkand independent general/Python code reviews passed.Prepared with AI assistance. Verification used mocked API responses without live model calls.