Repository navigation
test(s16): compare concurrent agent events without scheduler order - #623
Merged
Merged
Conversation
agent() records its progress event when the runner returns, and pipeline()/parallel() intentionally let agents finish in any order. Python 3.13/3.14 interleave those completions differently (and vary between runs), so compare workflow_agent events as a multiset while still asserting phase order, log placement, and phase tags.
Contributor
Author
|
CI 说明:当前两个 Vercel 检查失败是部署账号被 blocked( |
ruohai0925
pushed a commit
to ruohai0925/learn-claude-code
that referenced
this pull request
Nov 17, 2026
…I-lab#623) agent() records its progress event when the runner returns, and pipeline()/parallel() intentionally let agents finish in any order. Python 3.13/3.14 interleave those completions differently (and vary between runs), so compare workflow_agent events as a multiset while still asserting phase order, log placement, and phase tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test_s16_scenario_matches_the_deterministic_runtimecompares the full progress list, including the order of concurrentworkflow_agentevents.agent()appends its event when the runner returns, andpipeline()/parallel()intentionally let agents finish in any order. Python 3.13 and 3.14 interleave those completions differently (and the order varies between runs), while the event set is identical and the runtime behavior is unchanged.Fixes #622.
Change
workflow_agentevents as a multiset keyed by phase/label/status, keeping every other field and every non-agent event in exact order.verify:*agent events after the Verify phase event, and the workflow log last.Verification
tests/test_web_scenarios.py: 5 passed, 1 pre-existing failure (test_generated_s16_metadata_extends_s15_without_registry_false_positives, staleversions.json) on all versions.fcntlshim (not committed). Linux/macOS CI was not run locally.python-smokejob currently has the same pre-existingversions.jsonfailure unrelated to this PR (see chore(web): regenerate course data from current chapters #621).AI assistance was used for implementation and verification; the human submitter reviewed the final diff and evidence.