Skip to content

Disable Skylight when running in development environment #3

Open

Description

@JonRCahill

Skylight currently runs in all environments even when a blank SKYLIGHT_AUTHENTICATION has been set. The biggest issue this causes is that shutting down the Phoenix server will take 1 min when integrated with Skylight. This additionally affects running tests with mix test if the server option has been enabled.

Happy to do this myself if I can be pointed to the best way to disable Skylight.

Activity

  1. wagenet commented on Feb 22, 2017

    @wagenet
    Contributor

    Thanks for catching this. The Ruby gem won't boot the native agent if there isn't a token, we should do the same here. Also, it should be possible to have the shutdown not block on the native daemon. The daemon won't shut down immediately but after a little bit will realize it's not getting anything from the main app and shut down on its own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions