Skip to content

ReactorClientHttpRequestFactory should use HttpClient.create().proxyWithSystemProperties() #34849

Closed as not planned

Description

@siom79

Currently the ReactorClientHttpRequestFactory creates within the default constructor an instance of HttpClient just with create():

	public ReactorClientHttpRequestFactory() {
		this(defaultInitializer.apply(HttpClient.create()));
	}

In this setup the HttpClient does not apply any system properties for proxy settings (like e.g. https.proxyHost and https.proxyPort ). Therefore the following code is necessary:

	public ReactorClientHttpRequestFactory() {
		this(defaultInitializer.apply(HttpClient.create().proxyWithSystemProperties()));
	}

As other http client implementations such as Apache HttpClient do apply system properties for proxies in the default setup, this should be the same for the netty http client inside the ReactorClientHttpRequestFactory.

Activity

  1. added
    in: webIssues in web modules (web, webmvc, webflux, websocket)
    and removed on May 2, 2025
  2. added this to the 7.0.0-M5 milestone on May 2, 2025
  3. added a commit that references this issue on May 2, 2025
    1be1608
  4. bclozel commented on May 2, 2025

    @bclozel
    Member

    Superseded by #34850

  5. removed this from the 7.0.0-M5 milestone on May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in: webIssues in web modules (web, webmvc, webflux, websocket)status: supersededAn issue that has been superseded by anothertype: enhancementA general enhancement

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions