Repository navigation
Honor the declared charset in the Protobuf JSON codecs - #37557
Closed
sharanggupta wants to merge 1 commit into
Closed
sharanggupta wants to merge 1 commit into
sharanggupta wants to merge 1 commit into
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
ProtobufJsonDecoder read its input through an InputStreamReader created without a charset, so with the platform default, and ProtobufJsonEncoder always wrote UTF-8; both ignored the charset parameter of the media type. The servlet and messaging Protobuf converters use the declared charset, and UTF-8 by default. The codecs now do the same. Signed-off-by: Sharang Gupta <sharang@sharanggupta.dev>
sharanggupta
force-pushed
the
protobuf-json-charset
branch
from
November 8, 2026 18:30
4e3a02d to
4ffc156
Compare
Member
|
Thanks for the PR, but we won't be merging it. JSON must be UTF-8 (per the official RFC 8259), and "application/json" defines no charset parameter. That's why If anything |
bclozel
added
status: declined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProtobufJsonDecoderreads its input through anInputStreamReadercreated without a charset, so with the platform default, andProtobufJsonEncoderalways writes UTF-8. Both ignore the charset parameter of the media type, for exampleapplication/json;charset=ISO-8859-1, whereasProtobufJsonFormatHttpMessageConverterand the messagingProtobufMessageConverteruse the declared charset and UTF-8 by default. On JDK 17, where the default charset is still platform-dependent, the decoder can also mis-read UTF-8 input that declares no charset.This change makes both codecs use the charset of the MIME type, if any, and UTF-8 otherwise, as
AbstractCharSequenceDecoderandCharSequenceEncoderdo.ProtobufJsonDecoderTests#decodeToMonoWithCharsetandProtobufJsonEncoderTests#encodeWithCharsetcover a non-ASCII value declared as ISO-8859-1; both fail without the change. The protobuf codec tests ofspring-weband checkstyle pass.