Skip to content

chore: warn on an unreadable keychain key #1906

Open

Description

@ovitrif

Follow-up to #1897, which added a macOS keychain fallback to localProp in app/build.gradle.kts. Two non-blocking review points from @coreyphillips:

  • Unreadable keychain item looks like a missing one (thread): keychainProp ignores the exit value of security, so a locked keychain or a denied access prompt yields an empty key with no hint, and a mainnet build runs with Spark off. Only exit 44 means the item is missing. Log a warning for any exit other than 0 and 44.
  • One security process per unset key (thread): the fallback runs for every unset localProp key (about 13 for a debug variant), on every build including configuration-cache reuse, about 20 ms each. Applying it only to BREEZ_API_KEY matches the documented scope and the iOS twin, feat: read the breez api key from the keychain bitkit-ios#1317.

Activity

  1. added this to the 3.2.0 milestone on Nov 12, 2026
  2. changed the title [-]chore: narrow the keychain fallback in localProp[/-] [+]chore: warn on an unreadable keychain key[/+] on Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions