You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up to #1897, which added a macOS keychain fallback to localProp in app/build.gradle.kts. Two non-blocking review points from @coreyphillips:
Unreadable keychain item looks like a missing one (thread): keychainProp ignores the exit value of security, so a locked keychain or a denied access prompt yields an empty key with no hint, and a mainnet build runs with Spark off. Only exit 44 means the item is missing. Log a warning for any exit other than 0 and 44.
One security process per unset key (thread): the fallback runs for every unset localProp key (about 13 for a debug variant), on every build including configuration-cache reuse, about 20 ms each. Applying it only to BREEZ_API_KEY matches the documented scope and the iOS twin, feat: read the breez api key from the keychain bitkit-ios#1317.
Activity
[-]chore: narrow the keychain fallback in localProp[/-][+]chore: warn on an unreadable keychain key[/+]