You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Remove the BIP 321 rewrite after the bitkit-core bump #1935
Numo point-of-sale terminals send bitcoin:?lightning=<BOLT11> (BIP 321, no address) over NFC. bitkit-core up to v0.8.0-rc15 returns InvalidAddress for that form. The NFC payments PR (#1883) works around it in the app: scannedPaymentRequest rewrites bitcoin:?lightning=X and bitcoin:?lno=X to lightning:X, for NFC and Bluetooth reads only.
synonymdev/bitkit-core#218 (merged 2026-11-16, not in a release yet) decodes BIP 321 URIs without an address in core. Once a release includes it, the rewrite is redundant, and QR codes in the Numo form also start working.
The rewrite also turns bitcoin:?lightning=<LNURL> into lightning:<LNURL>, which core decodes only as BOLT11, so that form fails today. Core decodes it correctly once the rewrite is gone.
Bump bitkit-core in gradle/libs.versions.toml to that release. The release also has other breaking changes: wake_set_topics returns WakeSubscription, and any req- parameter (req-pop included) now returns InvalidFormat.
Remove scannedPaymentRequest from app/src/main/java/to/bitkit/nfc/NfcPaymentUri.kt and its call sites:
Triage: this goes in the 3.2.0 milestone with the NFC payments it follows (#1740), since 3.2.0 takes a bitkit-core release anyway; one with synonymdev/bitkit-core#218 lets the rewrite go and fixes the Numo QR and LNURL forms.
Activity
ovitrif commentedon Nov 16, 2026
Triage: this goes in the 3.2.0 milestone with the NFC payments it follows (#1740), since 3.2.0 takes a bitkit-core release anyway; one with synonymdev/bitkit-core#218 lets the rewrite go and fixes the Numo QR and LNURL forms.