Skip to content

Remove the BIP 321 rewrite after the bitkit-core bump #1935

Open

Description

@jvsena42

Problem

Numo point-of-sale terminals send bitcoin:?lightning=<BOLT11> (BIP 321, no address) over NFC. bitkit-core up to v0.8.0-rc15 returns InvalidAddress for that form. The NFC payments PR (#1883) works around it in the app: scannedPaymentRequest rewrites bitcoin:?lightning=X and bitcoin:?lno=X to lightning:X, for NFC and Bluetooth reads only.

synonymdev/bitkit-core#218 (merged 2026-11-16, not in a release yet) decodes BIP 321 URIs without an address in core. Once a release includes it, the rewrite is redundant, and QR codes in the Numo form also start working.

The rewrite also turns bitcoin:?lightning=<LNURL> into lightning:<LNURL>, which core decodes only as BOLT11, so that form fails today. Core decodes it correctly once the rewrite is gone.

Depends on

To do

  • Bump bitkit-core in gradle/libs.versions.toml to that release. The release also has other breaking changes: wake_set_topics returns WakeSubscription, and any req- parameter (req-pop included) now returns InvalidFormat.
  • Remove scannedPaymentRequest from app/src/main/java/to/bitkit/nfc/NfcPaymentUri.kt and its call sites:
    • app/src/main/java/to/bitkit/ui/shared/effects/NfcEffects.kt (readPaymentText)
    • app/src/main/java/to/bitkit/nearby/NearbyScanner.kt
  • Remove the scannedPaymentRequest cases from NfcPaymentUriTest. Keep the Square and Numo fixtures in NdefCodecTest and NearbyRequestFilterTest.

Check

  • NFC: a Numo-style tag (bitcoin:?lightning=<BOLT11>, any case) opens the Lightning send flow.
  • Bluetooth: the same request from a nearby device.
  • QR: bitcoin:?lightning=<BOLT11> and bitcoin:?lightning=<LNURL> scan.
  • Square's lightning:<UPPERCASE BOLT11> still works.

Twin: synonymdev/bitkit-ios#1344

Activity

  1. self-assigned this
    on Nov 16, 2026
  2. added this to the 3.2.0 milestone on Nov 16, 2026
  3. ovitrif commented on Nov 16, 2026

    @ovitrif
    Collaborator

    Triage: this goes in the 3.2.0 milestone with the NFC payments it follows (#1740), since 3.2.0 takes a bitkit-core release anyway; one with synonymdev/bitkit-core#218 lets the rewrite go and fixes the Numo QR and LNURL forms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions