Skip to content

Add realpath library function - #121

Open
joshblum wants to merge 4 commits into
szwacz:masterfrom
joshblum:joshblum/realpath
Open

joshblum wants to merge 4 commits into
szwacz:masterfrom
joshblum:joshblum/realpath

Conversation

@joshblum

@joshblum joshblum commented Jan 5, 2024

Copy link
Copy Markdown

No description provided.

@szwacz

szwacz commented Jan 16, 2024

Copy link
Copy Markdown
Owner

Thanks for the PR. I have problem finding windows dev machine to tinker with failed tests ;)
Will come back to it.

@joshblum

Copy link
Copy Markdown
Author

Took a guess at what the windows problem could be but also don't have a windows dev machine setup. Could you try running CI again on the change? Thanks!

@codecov

codecov Bot commented Jan 19, 2024 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.45763% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.94%. Comparing base (79f53db) to head (f211f50).

Files with missing lines Patch % Lines
lib/realpath.js 90.47% 2 Missing ⚠️
spec/realpath.spec.ts 98.86% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   96.92%   96.94%   +0.01%     
==========================================
  Files          52       54       +2     
  Lines        4624     4740     +116     
  Branches       25       25              
==========================================
+ Hits         4482     4595     +113     
- Misses        123      126       +3     
  Partials       19       19              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants