Skip to content

Add page number to json output - #473

Merged
jazzido merged 2 commits into
tabulapdf:masterfrom
martinswanson:add-page-number-to-json-output
Mar 8, 2022
Merged

jazzido merged 2 commits into
tabulapdf:masterfrom
martinswanson:add-page-number-to-json-output

Conversation

@martinswanson

Copy link
Copy Markdown

Currently, the JSON output does not contain any metadata to link back to the page in the source PDF document that data was extracted from.

  • add page_number to the JSON output.
  • update test JSON files to include the new page_number
  • all tests passing

@martinswanson

Copy link
Copy Markdown
Author

AppVeyor CI check is failing with the following error message:

The build phase is set to "MSBuild" mode (default), but no Visual Studio project or solution files were found in the root directory. If you are not building Visual Studio project switch build mode to "Script" and provide your custom build command.

I think this is a permissioning issue that must be fixed by someone with write access to the repo?

@jazzido

jazzido commented Mar 8, 2022

Copy link
Copy Markdown
Contributor

Great addition, I like it. Thanks!

@jazzido
jazzido merged commit 56cd713 into tabulapdf:master Mar 8, 2022
@martinswanson
martinswanson deleted the add-page-number-to-json-output branch March 8, 2022 14:04
@RR-Rico

RR-Rico commented Mar 17, 2023 •

Copy link
Copy Markdown

This is not in the latest release correct? I don't get the pages attribute in the json output.

Did you merge the wrong commit? @jazzido

EDIT:

My bad, did not check the year correctly. The release is older than the merge. It works with the latest build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants