Repository navigation
Escape JS theme configuration keys - #14739
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @philipp-spiess and the rest of your teammates on |
philipp-spiess
marked this pull request as ready for review
October 21, 2024 15:25
philipp-spiess
force-pushed
the
10-21-escape_js_theme_configuration_keys
branch
from
October 21, 2024 15:29
6e8312c to
fb06b4c
Compare
philipp-spiess
force-pushed
the
10-21-escape_js_theme_configuration_keys
branch
2 times, most recently
from
October 22, 2024 11:34
99072ca to
f99717b
Compare
philipp-spiess
commented
Oct 22, 2024
thecrypticace
approved these changes
Oct 22, 2024
Contributor
Author
Merge activity
|
This PR fixes two issues related to how we tread JS theme keys in combination with CSS theme values: 1. When applying JS theme keys to our `Theme` class, we need to ensure they are escaped in the same way as reading CSS theme keys from CSS are. 2. When JS plugins use the `theme()` function to read a namespace that has values contributed to from the CSS theme and the JS theme, we need to ensure that the resulting set contains only unescaped theme keys. For specific examples, please take a look at the test cases.
RobinMalfait
force-pushed
the
10-21-escape_js_theme_configuration_keys
branch
from
October 22, 2024 16:56
730b615 to
816e730
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues related to how we tread JS theme keys in combination with CSS theme values:
Themeclass, we need to ensure they are escaped in the same way as reading CSS theme keys from CSS are.theme()function to read a namespace that has values contributed to from the CSS theme and the JS theme, we need to ensure that the resulting set contains only unescaped theme keys.For specific examples, please take a look at the test cases.