Repository navigation
Conversation
DABH
marked this pull request as ready for review
October 26, 2026 22:57
brianstrauch
approved these changes
Oct 28, 2026
| testImplementation('io.temporal:temporal-testing') { | ||
| version { | ||
| strictly '[1.40.0,2.0[' | ||
| prefer '1.40.0' |
Contributor
There was a problem hiding this comment.
Why prefer ? I don't think any of our other samples declare this and not really sure why we would prefer 1.40.0? Generally we always want people running the latests version of the SDK
Quinn-With-Two-Ns
approved these changes
Oct 30, 2026
Contributor
|
Not blocking but I would consider just depending on the SDK version in the samples repo since that is kept up to date with the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Google ADK Java scenarios using the published Public Preview
io.temporal:google-adk:0.1.1plugin: Agent Chat, deterministic and Activity tools, stateless Java MCP, human approval, structured output, native parallel agents, and long-running tool callbacks.Every scenario has Temporal CLI instructions, live Gemini mode, and a credential-free offline mode using the same plugin, Worker registration, Workflows, Activities, and messages. This module requires SDK/testing 1.40.0+ within the 1.x series without changing other samples' dependencies.
Streaming and native ADK observability are unsupported; follow-ups are live delivery during model Activities and replay-safe ADK tracing. Agent-facing Sandboxes are also unsupported.