Repository navigation
Stamp the time-skipping config on update-with-start workflows - #2017
Open
LindseyZ1205 wants to merge 1 commit into
Open
LindseyZ1205 wants to merge 1 commit into
LindseyZ1205 wants to merge 1 commit into
Conversation
TimeSkipper's client interceptor only set time_skipping_config in start_workflow(), so workflows started with update-with-start ran without time skipping.
tconley1428
reviewed
Oct 23, 2026
GregoryTravis
previously approved these changes
Oct 26, 2026
Contributor
|
Needs a changelog fragment to detail the change for a user. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TimeSkipperandWorkflowEnvironment.start_time_skipping_v2()stamp aTimeSkippingConfigon every workflow started through their client, but_TimeSkippingConfigOutboundonly setstime_skipping_configinstart_workflow(). Update-with-start goes throughstart_update_with_start_workflow()instead, so a workflow started withexecute_update_with_start_workflow()orstart_update_with_start_workflow()runs without time skipping, and its timers fire in real time.UpdateWithStartStartWorkflowInput.time_skipping_configexists and is sent in the start request, but nothing sets it.For example, in an environment from
start_time_skipping_v2(), a workflow that sleeps for an hour returns in about a second when it's started withstart_workflow(). Started withexecute_update_with_start_workflow(), the same workflow has notime_skipping_configin itsWorkflowExecutionStartedevent,get_time_skipping_info()returnsNonefor it, and it's still waiting for its timer 10 seconds later.This change sets the config in
start_update_with_start_workflow()too, unless time skipping is disabled withwith_time_skipping_disabled(), as instart_workflow(). In the review of #1959, signal-with-start was found to go throughstart_workflow(); update-with-start is the other way to start a workflow from the client.test_update_with_start_stamps_time_skipping_configintests/testing/test_timeskipping_v2.pydoes whattest_signal_with_start_stamps_time_skipping_configdoes, with update-with-start. It checks the time skipping info of the workflow before waiting for its result, so onmainit fails right away (assert None is not None) instead of waiting for the timer.Time Skipping V2 isn't released yet (
changelog/added/leapfrogging-lemur.mdis still there), so, as in #1973, I didn't add a changelog fragment.Validation, with Python 3.12, the local dev server (
v1.8.3-server-1.32.0-162.0), and the Rust bridge of the temporalio 1.34.0 wheel:tests/testing/test_timeskipping_v2.py(21 tests) andtests/worker/test_update_with_start.py(34 tests) pass.ruff check --select Iandruff format --check(ruff 0.15.22), pyright 1.1.403, basedpyright 1.34.0 andmypy --namespace-packages --check-untyped-defspass on the changed files, and pydocstyle passes on the changed source file.