Repository navigation
Improve the signature of json_decode function #414
Description
The native json_decode function returns:
- null in case of an error
- an stdClass if the $assoc parameter is false
- an associative array if it's true
Since the safe implementation throws by default, the null value ia never returned. I thin we can improve the phpdoc return type of this function so that the return type is deduced depending on the value of $assoc parameter so that we can leverage better type checking using phpstan (https://phpstan.org/blog/phpstan-1-6-0-with-conditional-return-types)
Activity
cedric-anne commentedon May 13, 2025
Actually
json_decodecan return a null value, if you decode thenullstring:[-]Improve the signature of json_decode function[/-][+]Improve the signature of `json_decode` function[/+]oprypkhantc commentedon May 28, 2025
JSON isn't just arrays and objects.
null,1,1.25,true,false,"string"- are all valid JSON values, so the function may returnnull|int|float|bool|string|array|stdClasseven in case of valid JSON