Skip to content

Skips database selection if the router is not configured. - #1915

Merged
henadzit merged 2 commits into
tortoise:developfrom
henadzit:perf/router
Mar 12, 2025
Merged

henadzit merged 2 commits into
tortoise:developfrom
henadzit:perf/router

Conversation

@henadzit

@henadzit henadzit commented Mar 3, 2025 •

Copy link
Copy Markdown
Contributor

Description

Skips database selection if the router is not configured.

Motivation and Context

Improves performance by 2-4%:
Screenshot 2025-03-12 at 09 29 09

How Has This Been Tested?

make ci

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codspeed

codspeed Bot commented Mar 3, 2025 •

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #1915 will not alter performance

Comparing henadzit:perf/router (0cb8da1) with develop (a399d1a)

Summary

✅ 16 untouched benchmarks

@coveralls

coveralls commented Mar 3, 2025 •

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 13807013370

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 89.348%

Files with Coverage Reduction New Missed Lines %
tortoise/router.py 7 51.06%
Totals Coverage Status
Change from base Build 13634120781: -0.09%
Covered Lines: 6592
Relevant Lines: 7198

💛 - Coveralls

@henadzit henadzit changed the title WIP Skip router if no routers configured Skips database selection if the router is not configured. Mar 12, 2025
@henadzit
henadzit marked this pull request as ready for review March 12, 2025 08:36
@henadzit
henadzit requested review from abondar and waketzheng March 12, 2025 08:36
@henadzit
henadzit merged commit 529edcc into tortoise:develop Mar 12, 2025
@henadzit henadzit mentioned this pull request Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants