Repository navigation
Conversation
Modern setuptools with pyproject.toml defaults to include_package_data=True, which includes all version-controlled files in package directories. Since binding.c lives inside the tree_sitter_javascript package directory, it gets installed alongside the compiled extension. This triggers rpmlint devel-file-in-non-devel-package warnings on distributions that lint for development files in runtime packages. Exclude *.c files from the installed package data. The C sources are still used as compilation inputs during the build, but are no longer shipped in the wheel or installed site-packages. Signed-off-by: Maxime Ripard <mripard@kernel.org>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern setuptools with pyproject.toml defaults to
include_package_data=True, which includes all version-controlled files in package directories. Since binding.c lives inside the tree_sitter_javascript package directory, it gets installed alongside the compiled extension.
This triggers rpmlint devel-file-in-non-devel-package warnings on distributions that lint for development files in runtime packages.
Exclude *.c files from the installed package data. The C sources are still used as compilation inputs during the build, but are no longer shipped in the wheel or installed site-packages.