Repository navigation
Conversation
added 7 commits
September 6, 2026 10:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$refsite bare.What happened
Probability-mode Choice and Score answers use nested probability-map models. Before PR #31, Pydantic emitted their question and criteria in a
descriptionbeside the field's$ref. Anthropic's Python SDK structured-output transformer silently emitted only$ref, without an error or warning, so Anthropic received option names and numeric bounds but not the question or criteria. OpenAI preserved the description, and prompted mode serialized the unmodified raw schema into the prompt.The same early-return behavior is discussed in anthropic-sdk-python #1642, although that issue focuses on a dropped
$defssibling.structured_outputs=True)structured_outputs=False)Schema placement
$ref, so behavior-critical context does not depend on sibling-keyword preservation or Pydantic deduplication.$refin both native provider requests and verifies that its question and criteria remain inside the provider schema.Dependency
Stacked on #31, which establishes the referenced-definition workaround. This layer refines where criteria live and adds the compatibility documentation.
Verification
uv run pytest --record-mode=none— 70 passed.uv run ruff check --fix src/system_one_client_adapter/utils/pydantic_utils.py tests/test_client_with_live_apis.pyuv run git diff --check