Repository navigation
test: cover ASCII DEL boundary - #2943
Open
renanmpimentel wants to merge 1 commit into
Open
renanmpimentel wants to merge 1 commit into
renanmpimentel wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2943 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2599 2599
Branches 658 658
=========================================
Hits 2599 2599 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this test matters
Narrowing the ASCII character class by one code point would incorrectly reject DEL (
0x7F) while all earlier cases pass. One public-API test now protects that upper boundary.Supertest audit method
I used the Supertest test-audit skill to probe whether the existing suite would catch a plausible violation of this contract. The regression was applied only in an isolated worktree. The regression proof records three executed states: the existing tests pass with that regression, the new assertion fails against the same regression, and the new test passes with the original production code restored. The published diff adds tests only.
Adds the DEL character (
0x7F) to theisAsciiregression cases. DEL is the upper boundary of the ASCII range accepted by the implementation.Proof: narrowing the character class from
\x00-\x7Fto\x00-\x7Eleaves all 323 existing tests passing, but fails this new public API assertion. With the production regex restored, the fullnpm testsuite passes with 323 tests and lint;node --check test/validators.test.jsandgit diff --checkalso pass.This PR changes tests only.
Checklist
npm testpassed locally.Repository guidance
AGENTS.mdandCONTRIBUTING.mdcall for a focused regression test,npm test, and no generated-file edits; the diff is one test line. The repository template checklist is included below.