Skip to content

Revision ignored if create_repo_from_pip_url is used #293

Closed

Description

@jensens

Expected: If one passes an pipurl with a ...@some-branch the branch should be picked.

Current behavior: It ignores the given branch and uses the default branch (like master or main).

Analysis:

  • rev is parsed correctly
  • rev is passed to the specialized classes constructor as kwarg, i.e. for Git.
  • from there rev is passed to the base class constructor as kwarg.
  • In the base class constructor all kwargs are ignored.

Solution:
If a kwargs rev is passed to the base constructor, stored it as an instance variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions