Repository navigation
Give each inline V2 scan root its own IO session - #11226
Merged
Merged
Conversation
Inline roots shared one session, and the run clears a root's session when the root retires. Once the first root finished, the remaining roots waited for reads that were never issued. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MZ3d6HFyGGeUGy8brEr6BM Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
A scan concurrency of 0 runs every chunk on the scan's own run as another root. With one shared IO session, the first chunk to retire cleared the reads of the others and the scan hung. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeniBCw9H5HzcnWiPpiQjH Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
robert3005
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the DataFusion V2 scan driver runs chunks inline (
concurrency × available parallelism <= 1), it admits each spawned chunk to the scan's ownRunas another root. Every root was given the sameIoSourcesession. The run clears a root's session when that root retires, so once the first chunk finished, itsclear()cancelled the reads of the others, and they waited forever for completions that never came.vortex-datafusion/src/persistent/scan_v2.rs:RunStateholds the scan'sIoServiceinstead of a single session, and the driver callsio.session()for every root it admits: the first root and each inline child. Each root's session is now cleared on its own. All sessions still read from the sameSegmentSource.