Repository navigation
Keep IntDictScheme for chunks DictStrategy rejects - #11331
Merged
Merged
Conversation
The default write strategy excluded IntDictScheme from the compressor shared by DictStrategy's codes and fallback paths. Columns that DictStrategy rejects, including every decimal column, could therefore never use integer dictionaries, e.g. for a DecimalByteParts most significant part. Give the fallback its own pipeline with the full compressor and keep the IntDictScheme exclusion only for dictionary codes. Add a roundtrip test for a decimal whose most significant part is dict-encoded inside byte parts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018SWbEu3keyvDQYHhiRs87n Signed-off-by: Robert Kruszewski <robert@spiraldb.com>
Clones of a VortexSession share state, so both rstest cases registered LayoutSession on the module's shared static session and whichever case ran second panicked. The registration also leaked into the other tests that use that session, depending on run order. Build a fresh session in the test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018SWbEu3keyvDQYHhiRs87n Signed-off-by: Robert Kruszewski <robert@spiraldb.com>
connortsui20
reviewed
Nov 9, 2026
connortsui20
marked this pull request as ready for review
November 9, 2026 16:14
Split the configured compressor into codes and full compressors in CompressorConfig::into_compressors, and build each coalesce-then-compress pipeline with coalesce_then_compress, so build calls it once for dict codes and once for the fallback. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018SWbEu3keyvDQYHhiRs87n Signed-off-by: Robert Kruszewski <robert@spiraldb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default write strategy removed
IntDictSchemefrom the one compressor shared byDictStrategy's codes path and its fallback path. The exclusion is only needed for dictionary codes, so they aren't dictionary-encoded twice. But it also applied to every columnDictStrategyrejects, and those could never use integer dictionaries, even nested inside another encoding. This hits decimals hardest: they always take the fallback, so aDecimalBytePartsmost significant part could never be dict-encoded.