Skip to content

Move the DecimalByteParts tests into their own files - #11456

Merged
connortsui20 merged 2 commits into
developfrom
ct/dbp-test-modules
Nov 13, 2026
Merged

connortsui20 merged 2 commits into
developfrom
ct/dbp-test-modules

Conversation

@connortsui20

@connortsui20 connortsui20 commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Summary

#11458 and #11459 change both the code and the tests of array.rs, assemble.rs, and split.rs. This PR is a purely cosmetic change.

Move array.rs, assemble.rs, and split.rs to array/mod.rs, assemble/mod.rs,
and split/mod.rs. Move the inline test module of each file into a tests.rs
next to it.

This changes no code. Each test body loses one level of indentation, and
rustfmt joins a few lines after that. The test names do not change.

To check the move, run:

    git show -M40% --color-moved --color-moved-ws=allow-indentation-change

Git needs the lower rename threshold to pair array.rs and assemble.rs with
their new mod.rs, because about half of each file moved to tests.rs.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Put each re-export under its module and the test modules last, name
the filter test module tests, move the test helpers to the top of their
files, and add blank lines before final returns.

Write test_scalar_at_decimal_parts as a table loop, and merge
test_split_assemble_i128 and test_split_assemble_i256 into one generic
test_split_assemble. Both keep the same cases and values.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 added the changelog/chore A trivial change label Nov 13, 2026
@connortsui20 connortsui20 changed the title ct/dbp test modules Move the DecimalByteParts tests into their own files Nov 13, 2026
@connortsui20
connortsui20 marked this pull request as ready for review November 13, 2026 17:56
@connortsui20
connortsui20 merged commit f5d4d6d into develop Nov 13, 2026
161 checks passed
@connortsui20
connortsui20 deleted the ct/dbp-test-modules branch November 13, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants