Repository navigation
Move the DecimalByteParts tests into their own files - #11456
Merged
Merged
Conversation
Move array.rs, assemble.rs, and split.rs to array/mod.rs, assemble/mod.rs,
and split/mod.rs. Move the inline test module of each file into a tests.rs
next to it.
This changes no code. Each test body loses one level of indentation, and
rustfmt joins a few lines after that. The test names do not change.
To check the move, run:
git show -M40% --color-moved --color-moved-ws=allow-indentation-change
Git needs the lower rename threshold to pair array.rs and assemble.rs with
their new mod.rs, because about half of each file moved to tests.rs.
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Put each re-export under its module and the test modules last, name the filter test module tests, move the test helpers to the top of their files, and add blank lines before final returns. Write test_scalar_at_decimal_parts as a table loop, and merge test_split_assemble_i128 and test_split_assemble_i256 into one generic test_split_assemble. Both keep the same cases and values. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
marked this pull request as ready for review
November 13, 2026 17:56
robert3005
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#11458 and #11459 change both the code and the tests of
array.rs,assemble.rs, andsplit.rs. This PR is a purely cosmetic change.