Skip to content

Log the standalone startup message when the server is already listening - #18417

Open
matthewp wants to merge 1 commit into
mainfrom
triage-18381
Open

matthewp wants to merge 1 commit into
mainfrom
triage-18381

Conversation

@matthewp

Copy link
Copy Markdown
Contributor

Changes

  • Fixes the @astrojs/node standalone startup log being skipped on Node 26.12 when HOST is an IP literal: the log handler waits for the listening event after it may already have fired, so the "Server listening" line never prints (server still serves requests).
  • Adds an if (!server.listening) guard before waiting for the event, so the message is logged whenever the server is already up.

Testing

  • Adds a unit test for logListeningOn covering the already-listening case; hardened so the server is closed in an after() hook (the previous version hung the test runner when the assertion failed).

Docs

  • No docs update needed — startup log behavior only.

@changeset-bot

changeset-bot Bot commented Oct 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8ac55e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the pkg: integration Related to any renderer integration (scope) label Oct 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant