Repository navigation
Harden base64, time conversion and allocator helpers - #102
Open
aidangarske wants to merge 12 commits into
Open
aidangarske wants to merge 12 commits into
aidangarske wants to merge 12 commits into
Conversation
… handling in base64 pad lookahead
…ed quantums with too few data sextets
…ejection of conflicting add and clear bits
…oute private data alignment validation
…erogatory threshold range check
…ed success string table size arithmetic
…ve deadline conversion failures instead of substituting zero
…ne getter interval conversion failures
…ainst divided limits before microsecond multiplication
…conversion failures in timespec wrappers
…g count unchanged on a failed nonzero realloc
…nt and guard overflow in fallback aligned allocators
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #102
Scan targets checked: wolfsentry-src, wolfsentry-bugs
Coverage: 2 of 2 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
mattia-moffa
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-8757- 602c8b0 - Base64 decode now honors lenient junk handling in the pad lookahead.F-8771- 64419e1 - Base64 decode now rejects padded quantums with too few data sextets.F-2843- e33078d - A new test covers eventconfig rejection of conflicting add and clear bits.F-2849- becb539 - A new test covers eventconfig validation of route private data alignment.F-3190- a62efce - A new test covers the eventconfig derogatory threshold range check.F-1214- 782a20a - The user-defined success string table is now sized with the correct arithmetic.F-10495- f7a82c1 - Relative deadline conversion failures are now propagated instead of being replaced with zero.F-13886- 907f7c0 - The deadline getter now propagates interval conversion failures.F-13887- 3d3a212 - Seconds are now checked against divided limits before the microsecond multiply, so it cannot overflow.F-10496- f6ca337 - The timespec wrappers now propagate epoch conversion failures.F-10503- 45f8720 - The malloc debug count no longer changes on a failed nonzero realloc.F-10510- 03fdb18 - The fallback aligned allocators now validate alignment and guard against size overflow.