Repository navigation
Fix table cloning, ID allocation and teardown in internal tables - #105
Open
aidangarske wants to merge 4 commits into
Open
aidangarske wants to merge 4 commits into
aidangarske wants to merge 4 commits into
Conversation
…n cloning coupled address family tables
…null ID when the entry ID counter wraps
… entry ID on delete instead of the second newest
…tructor failures during table teardown instead of ignoring them
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #105
Scan targets checked: wolfsentry-src, wolfsentry-bugs
Coverage: 1 of 2 in-scope changed file(s) opened by the reviewer; not opened: tests/unittests.c
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-6255- 3f2cfcc - Cloning coupled address family tables now sets the prev links.F-4280- a87b758 - The entry ID counter now skips the reserved null ID when it wraps.F-8755- 4dde8bb - Delete now reclaims the newest entry ID instead of the second newest.F-10490- 93eaec3 - Entry destructor failures during table teardown are now reported, and teardown continues so the shutdown mutex is released.