Repository navigation
Fail closed in the lwIP packet filter glue - #108
Open
aidangarske wants to merge 7 commits into
Open
aidangarske wants to merge 7 commits into
aidangarske wants to merge 7 commits into
Conversation
…when the wolfSentry dispatch fails
…when the filter callback has no wolfSentry context
…it action result for lwIP TCP close-wait events
…Pv4 filter mask and context when disabling the filter
…ilter context and mask before the callback pointer
…lter slots when the owning context releases them
…wolfSentry context only after its policy is loaded
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #108
Scan targets checked: wolfsentry-src, wolfsentry-bugs
Not reviewed (no scan target covers them): examples/STM32-LWIP/README.md, examples/STM32-LWIP/Src/sentry.c
Coverage: 1 of 2 in-scope changed file(s) opened by the reviewer; not opened: wolfsentry/wolfsentry_lwip.h
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
aidangarske
marked this pull request as ready for review
October 24, 2026 01:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-2438- d39d266 - The lwIP glue now denies a packet when wolfSentry dispatch fails.F-3866- 1e73174 - The lwIP glue now denies a packet when the filter callback has no wolfSentry context.F-10500- 9b71bb4 - lwIP TCP close-wait events now set the close-wait action result.F-3864- be804b7 - Disabling the lwIP ICMPv4 filter now clears its mask and context.F-3868- 7c76225 - The lwIP filter context and mask are now installed before the callback pointer.F-4762- dc2b5cc - lwIP filter slots are now cleared only by the owning context, and a non-owner gets INCOMPATIBLE_STATE.F-5004- 3687f4c - The STM32 example now publishes its wolfSentry context only after its policy is loaded.