Repository navigation
Fix locking and initialization in address family handling - #91
Open
aidangarske wants to merge 4 commits into
Open
aidangarske wants to merge 4 commits into
aidangarske wants to merge 4 commits into
Conversation
… family entry header before the fallible allocation path
…ocking on error paths reached before the context lock is held
…ddress family number before releasing the shared lock
…ton to match the ntop formatter
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #91
Scan targets checked: wolfsentry-src, wolfsentry-bugs
Coverage: 1 of 2 in-scope changed file(s) opened by the reviewer; not opened: tests/unittests.c
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-8776- a102f7e - Address family insert now initializes the entry header before the fallible allocation path, so cleanup never reads uninitialized fields.F-8752- c32d8be - Address family error paths reached before the context lock is held now return without unlocking it.F-8783- 9e5e03d - Address family lookup now copies the matched family number before releasing the shared lock.F-2856- 9d11323 - pton now accepts UNSPEC, matching what the ntop formatter emits.