Repository navigation
Fail closed in the Linux lwIP example - #93
Open
aidangarske wants to merge 6 commits into
Open
aidangarske wants to merge 6 commits into
aidangarske wants to merge 6 commits into
Conversation
…ry init and config load errors from sentry_init
…n when wolfSentry dispatch returns an error
…hen wolfSentry dispatch returns an error
…e when wolfSentry dispatch returns an error
… release the PCB when lwIP TCP setup fails
…n raw ICMP PCB allocation fails
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #93
Scan targets checked: wolfsentry-pr-general
Review type: general (no scan target covers the changed files)
Coverage: 3 of 3 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
aidangarske
marked this pull request as ready for review
October 24, 2026 01:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-4706- d613214 - sentry_init in the Linux lwIP example now propagates wolfSentry init and config load errors instead of running unfiltered.F-5706- d833205 - The Linux lwIP example now denies a TCP connection when wolfSentry dispatch returns an error.F-5705- bcb8cde - The Linux lwIP example now denies an ICMP packet when wolfSentry dispatch returns an error.F-5704- 632e5ee - The Linux lwIP example now denies an Ethernet frame when wolfSentry dispatch returns an error.F-4822- a52d12e - Echo init in the Linux lwIP example now halts and releases its PCB when TCP setup fails.F-4823- c5950bb - Ping init in the Linux lwIP example now halts when raw ICMP PCB allocation fails.