Repository navigation
Fix array path parsing and cleanup in centijson values - #95
aidangarske wants to merge 15 commits into
Conversation
… attached and negative array index path forms
…dex and count in array range removal
…ray on failure and track only initialized elements
…y without a zero-size allocation
…eric conversions in compatibility predicate
…ting values before casting in compatibility predicate
…tionary node and keep size consistent on finalize failure
…retryable by not freeing a still-linked node on cleanup failure
…tack allocation when cleaning or cloning an empty dictionary
…directly when shrinking to zero capacity
…est constants without C99 long long literals
…owth whose doubled capacity wraps instead of shrinking to zero
…ary stack walk when no stack was allocated for an empty tree
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #95
Scan targets checked: wolfsentry-src, wolfsentry-bugs
Not reviewed (no scan target covers them): tests/filter-clang-analyzer.py
Coverage: 1 of 2 in-scope changed file(s) opened by the reviewer; not opened: tests/unittests.c
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
Review tier: Lite
…ionary node before freeing it so a failed clean can be retried
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #95
Scan targets checked: wolfsentry-src, wolfsentry-bugs
Not reviewed (no scan target covers them): tests/filter-clang-analyzer.py
Coverage: 1 of 2 in-scope changed file(s) opened by the reviewer; not opened: tests/unittests.c
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
Fenrir's latest completed scan found no issues; clearing the prior automated change request.
F-11599- 3d30178 - JSON value paths now parse the documented attached and negative array index forms.F-8777- 76a1515 - Array range removal now rejects an index or count that wraps.F-8763- 5ee8a0b - A cloned array is now finalized on failure and only initialized elements are tracked.F-13882- 902f106 - Cloning an empty array no longer makes a zero-size allocation.F-10491- 737dc5f - The value compatibility predicate now rejects lossy numeric conversions.F-13888- 962014d - The value compatibility predicate now range checks floating values before casting them.F-11604- 156d92f - Dictionary removal now frees the removed node and keeps the size consistent when finalize fails.F-11603- 67dfd96 - Dictionary cleanup no longer frees a node that is still linked, so a failed cleanup can be retried.F-10499- 3992d02 - Cleaning or cloning an empty dictionary no longer makes a zero-size stack allocation.F-8754- e35340a - Shrinking an array to zero capacity now frees its buffer directly.