Repository navigation
Fail closed and validate ownership in the wolfIP filter glue - #97
Open
aidangarske wants to merge 10 commits into
Open
aidangarske wants to merge 10 commits into
aidangarske wants to merge 10 commits into
Conversation
…fecycle mask in combined wolfIP filter installer
…lter ownership before committing mask changes
…up registration when filters are disabled
…filter state when the owning context is destroyed
…ction result for wolfIP TCP close-wait events
…issociate to a neutral teardown result
…P and ICMP socket lifecycle reasons in the filter glue
…s with unmapped protocols or event reasons
…s when the wolfSentry dispatch fails
…lfIP TCP mask only when accept events are requested
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #97
Scan targets checked: wolfsentry-src, wolfsentry-bugs
Coverage: 1 of 1 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-10486- 3b80b25 - The combined wolfIP filter installer now normalizes the TCP lifecycle mask.F-8767- d3867ec - The wolfIP glue now validates filter ownership before committing any mask change.F-8784- 47b5c95 - Disabling the wolfIP filters now resets the cleanup registration.F-5006- bade91d - wolfIP filter state is now cleared only when the owning context is destroyed.F-10501- b807f48 - wolfIP TCP close-wait events now set the CLOSE_WAIT action result.F-10504- 6dc5013 - wolfIP TCP dissociate now maps to a neutral teardown result.F-13885- 4edb2d7 - The wolfIP glue now handles UDP and ICMP socket lifecycle reasons.F-2837- 7857511 - The wolfIP glue now denies packets with an unmapped protocol or event reason.F-2438- 33c5d5f - The wolfIP glue now denies a packet when wolfSentry dispatch fails instead of letting it through.F-10486- 1c1d5ca - The wolfIP TCP mask is now normalized only when accept events are requested.