Repository navigation
Publish: build only the sdist in the sdist job - #316
Merged
Merged
Conversation
maturin build --sdist also built a wheel for the host runner. For 0.6.0 it was tagged manylinux_2_34 and uploaded as a second x86_64 wheel; for 0.7.0 it was tagged linux_x86_64, and PyPI rejected the upload. The check meant to catch this looked in target/wheels, but --out writes to dist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NyN7idACeDMh94qrnFMu6h
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.7.0 upload to PyPI failed, and nothing was published:
Cause. The
Source distributionjob ranmaturin build --release --sdist --out dist. That builds the sdist and also a wheel for the runner's own Linux. The job's check for stray wheels looked intarget/wheels, but--out distwrites them todist/, so the extra wheel was merged into the upload.manylinux_2_34_x86_64. PyPI accepted it, which is why 0.6.0 has two x86_64 Linux wheels.linux_x86_64, which PyPI rejects.Fix.
maturin sdist --out dist, which builds only the sdist. I checked locally that it writes onlyxarray_sql-0.7.0.tar.gz..whlis indist/ortarget/wheels/.The release's Linux x86_64 wheel still comes from the
manylinux_2_28job, as before.🤖 Generated with Claude Code
https://claude.ai/code/session_01NyN7idACeDMh94qrnFMu6h