Repository navigation
Validate transport handshake conflict repair on current master - #76
Closed
Spicy-cream wants to merge 9 commits into
Closed
Spicy-cream wants to merge 9 commits into
Spicy-cream wants to merge 9 commits into
Conversation
The AMF0 number is a peer-controlled double; casting NaN or values outside [0, UINT32_MAX] to uint32_t is undefined behavior (UBSan float-cast-overflow) and decodes to different ids per platform. Validate the range before the cast.
/hotspots/* wrote view and base into its inline script without the ValidProfilePath check that its *_non_responsive handler already applies, and /rpcz printed the pointer of the time parameter instead of the escaped value.
* Add IPC_V2 data path for UBRing IPC * Move IPC_V2 ring implementation out of header --------- Co-authored-by: BGQ99 <1132767344@qq.com>
…lity Resolve UBSHM handshake conflicts using the tested rebased tree. Retain backend-specific format negotiation, remote shared-memory lengths, and upstream IPC V2 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI validation only
Companion to #75, using the identical source commit d9fc07d.
This draft targets master because the Linux and macOS workflows only run for that base branch. Do not merge this CI-only PR; integrate the actual repair through pull request 75 into transport-handshake.
The repair preserves upstream IPC_V2 support and tests, adapts the common handshake to backend-specific format negotiation, passes peer shared-memory lengths to resource mapping, and adds IPC_V2 protocol coverage.
Local validation: 28 common-handshake tests, 42 UBRing tests, and 92 RDMA tests passed. The 9 IPC_V2 adapter and upgraded-RPC tests also passed three repeated runs.