Skip to content

package-tests: stop a test that hangs; rtabmap_slam and aruco_ros tests stop their node - #202

Merged
Tobias-Fischer merged 1 commit into
mainfrom
ci/package-tests-timeout
Nov 9, 2026
Merged

Tobias-Fischer merged 1 commit into
mainfrom
ci/package-tests-timeout

Conversation

@Tobias-Fischer

Copy link
Copy Markdown
Collaborator

Fixes the nightly package tests' missing osx-arm64 results (#168).

Cause. humble osx-arm64 ran into the job's 180-minute limit every night (jazzy once too): humble's rtabmap_slam recipe test starts the SLAM node, sends SIGTERM and exits without waiting. On the macOS runners the node doesn't exit, holds the test's output open, and rattler-build test waits for it (as rko_lio's and fuse's tests did in their PRs). The job is then cancelled, and since the results are only written at the end, the report has nothing for the platform (about 120 packages had passed before). The log seemed to stop at rosx_introspection because each package's output is only printed once it finishes. Locally (osx-arm64) the node does exit and the test passes in 24 s.

Changes

  • tools/package_tests.py: each package's tests are stopped after 20 min (TEST_TIMEOUT): rattler-build test runs in its own process group and the whole group is killed (taskkill /T on Windows), so a leftover process can't keep the pipe open. The package is reported as failed with the output so far and a "stopped" line; a test that hung isn't retried. Tests: a test leaving a process behind that ignores SIGTERM is stopped after its timeout and failed; a normal test still passes.
  • shared/tests/ros2-rtabmap-slam.yaml, ros2-aruco-ros.yaml: kill the node 3 s after SIGTERM and wait for it, as rko_lio's and fuse's tests do.
  • The nightly run tests the test bundled in the published package, so rtabmap_slam (humble 23, jazzy 28, lyrical 31) and aruco_ros (humble 23, jazzy 28, lyrical 31, rolling 33) get build number bumps to republish them with the fixed test.

Checked locally: the tooling tests (74) and robostack.py check pass; the generated recipes carry the new build numbers and tests.

CI builds humble, jazzy and rolling. lyrical isn't labelled: its python 3.12 builds aren't published for macOS/Windows yet (#201), so a lyrical PR build there would build ~1000 packages; main builds lyrical's bumped packages after merging.

🤖 Generated with Claude Code

…ts stop their node

The nightly osx-arm64 job ran into its 3 h limit every night (#168):
humble's rtabmap_slam recipe test left its node running (SIGTERM ignored
on the runner), which held the test's output open. The job was cancelled
and no results were written, for every package of the platform.

- tools/package_tests.py: each package's tests are stopped after 20 min
  (the whole process group, the test's leftovers included) and reported
  as failed; such a test isn't retried.
- rtabmap_slam and aruco_ros: their recipe tests kill the node if SIGTERM
  doesn't end it and wait for it (as rko_lio's and fuse's), with build
  number bumps so the published packages carry the fixed test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Tobias-Fischer Tobias-Fischer added build:humble PR build: build only humble (with other build:<distro> labels: only those) build:jazzy PR build: build only jazzy (with other build:<distro> labels: only those) build:rolling PR build: build only rolling (with other build:<distro> labels: only those) labels Nov 8, 2026
@Tobias-Fischer
Tobias-Fischer enabled auto-merge (squash) November 8, 2026 23:35
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

ABI check (linux-64)

humble linux-64: 2 can be bumped on their own
2 packages can be bumped on their own (compatible: 2)
package released → PR verdict details
aruco-ros 5.0.6 (build 22) → 5.0.6 compatible: no ABI change
rtabmap-slam 0.23.13 (build 22) → 0.23.13 compatible: no ABI change headers unchanged

Compared with the newest builds on https://conda.anaconda.org/robostack-humble/linux-64.

jazzy linux-64: 2 can be bumped on their own
2 packages can be bumped on their own (compatible: 2)
package released → PR verdict details
aruco-ros 5.0.5 (build 27) → 5.0.5 compatible: no ABI change
rtabmap-slam 0.23.13 (build 27) → 0.23.13 compatible: no ABI change headers unchanged

Compared with the newest builds on https://conda.anaconda.org/robostack-jazzy/linux-64.

rolling linux-64: 1 can be bumped on their own
1 packages can be bumped on their own (compatible: 1)
package released → PR verdict details
aruco-ros 5.0.6 (build 32) → 5.0.6 compatible: no ABI change

Compared with the newest builds on https://repo.prefix.dev/robostack-rolling/linux-64.

About this check

Each package this pull request built, compared with its newest released build (tools/abi_check.py, libabigail):

  • compatible / additions: the package can be bumped on its own;
  • soname / incompatible: the packages that depend on it need a rebuild (build number bump) in the same pull request.

Exported symbols are compared (the released packages are stripped, so struct layouts aren't); unchanged installed headers rule out layout and inline changes, changed ones are listed for review. Dependents to rebuild are the released ones linking to a changed library. A changed pin is part of the comparison.

@Tobias-Fischer
Tobias-Fischer merged commit 81255cb into main Nov 9, 2026
28 checks passed
@Tobias-Fischer
Tobias-Fischer deleted the ci/package-tests-timeout branch November 9, 2026 00:02
Tobias-Fischer added a commit that referenced this pull request Nov 9, 2026
pkg_additional_info.yaml: both sides' build_number entries (#202).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build:humble PR build: build only humble (with other build:<distro> labels: only those) build:jazzy PR build: build only jazzy (with other build:<distro> labels: only those) build:rolling PR build: build only rolling (with other build:<distro> labels: only those)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant