Repository navigation
package-tests: stop a test that hangs; rtabmap_slam and aruco_ros tests stop their node - #202
Merged
Merged
Conversation
…ts stop their node The nightly osx-arm64 job ran into its 3 h limit every night (#168): humble's rtabmap_slam recipe test left its node running (SIGTERM ignored on the runner), which held the test's output open. The job was cancelled and no results were written, for every package of the platform. - tools/package_tests.py: each package's tests are stopped after 20 min (the whole process group, the test's leftovers included) and reported as failed; such a test isn't retried. - rtabmap_slam and aruco_ros: their recipe tests kill the node if SIGTERM doesn't end it and wait for it (as rko_lio's and fuse's), with build number bumps so the published packages carry the fixed test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tobias-Fischer
enabled auto-merge (squash)
November 8, 2026 23:35
ABI check (linux-64)humble linux-64: 2 can be bumped on their own2 packages can be bumped on their own (compatible: 2)
Compared with the newest builds on https://conda.anaconda.org/robostack-humble/linux-64. jazzy linux-64: 2 can be bumped on their own2 packages can be bumped on their own (compatible: 2)
Compared with the newest builds on https://conda.anaconda.org/robostack-jazzy/linux-64. rolling linux-64: 1 can be bumped on their own1 packages can be bumped on their own (compatible: 1)
Compared with the newest builds on https://repo.prefix.dev/robostack-rolling/linux-64. About this checkEach package this pull request built, compared with its newest released build (
Exported symbols are compared (the released packages are stripped, so struct layouts aren't); unchanged installed headers rule out layout and inline changes, changed ones are listed for review. Dependents to rebuild are the released ones linking to a changed library. A changed pin is part of the comparison. |
Tobias-Fischer
added a commit
that referenced
this pull request
Nov 9, 2026
pkg_additional_info.yaml: both sides' build_number entries (#202). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the nightly package tests' missing osx-arm64 results (#168).
Cause. humble osx-arm64 ran into the job's 180-minute limit every night (jazzy once too): humble's
rtabmap_slamrecipe test starts the SLAM node, sends SIGTERM and exits without waiting. On the macOS runners the node doesn't exit, holds the test's output open, andrattler-build testwaits for it (asrko_lio's and fuse's tests did in their PRs). The job is then cancelled, and since the results are only written at the end, the report has nothing for the platform (about 120 packages had passed before). The log seemed to stop atrosx_introspectionbecause each package's output is only printed once it finishes. Locally (osx-arm64) the node does exit and the test passes in 24 s.Changes
tools/package_tests.py: each package's tests are stopped after 20 min (TEST_TIMEOUT):rattler-build testruns in its own process group and the whole group is killed (taskkill /Ton Windows), so a leftover process can't keep the pipe open. The package is reported as failed with the output so far and a "stopped" line; a test that hung isn't retried. Tests: a test leaving a process behind that ignores SIGTERM is stopped after its timeout and failed; a normal test still passes.shared/tests/ros2-rtabmap-slam.yaml,ros2-aruco-ros.yaml: kill the node 3 s after SIGTERM and wait for it, asrko_lio's and fuse's tests do.rtabmap_slam(humble 23, jazzy 28, lyrical 31) andaruco_ros(humble 23, jazzy 28, lyrical 31, rolling 33) get build number bumps to republish them with the fixed test.Checked locally: the tooling tests (74) and
robostack.py checkpass; the generated recipes carry the new build numbers and tests.CI builds humble, jazzy and rolling. lyrical isn't labelled: its python 3.12 builds aren't published for macOS/Windows yet (#201), so a lyrical PR build there would build ~1000 packages; main builds lyrical's bumped packages after merging.
🤖 Generated with Claude Code