Repository navigation
vinca: order the build stages by the platform's requirements (vinca#191) - #201
Merged
Merged
Conversation
Main's lyrical osx-64 build ran ament_cmake_gmock's recipe test (under if: unix) before ament_cmake's new python 3.12 build existed: vinca-gha ignored requirements inside selectors around tests. Also brings vinca#193 (pkg_additional_info entries of ros2_*/ros_* packages were ignored; none on main). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tobias-Fischer
enabled auto-merge (squash)
November 8, 2026 23:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps vinca from 4ff3e37 to 74d1e85:
vinca-ghaevaluates the recipes' platform selectors for the workflow's platform when ordering the build stages. Before, it ignored requirements inside a selector around a test, so main's lyrical osx-64 build ranament_cmake_gmock's recipe test (if: unix, needsros2-ament-cmake) before ament_cmake's new python 3.12 build existed (failed job). Generating that workflow locally:ament_cmake_gmockwas in the same stage asament_cmake; with this vinca it's in the next one. Otherwise the same 191 jobs in 47 stages.pkg_additional_info.yamlentries of packages whose ROS name starts withros2_/ros_were ignored (the name was normalized twice). No such entries exist on main, so nothing changes now.Checked locally:
robostack.py checkpasses; humble and rolling generate 0 recipes for osx-arm64 (nothing extra to rebuild).CI:
build:none.🤖 Generated with Claude Code