Repository navigation
pkg_additional_info: don't normalize a ROS name twice (ros2_pulse -> pulse) - #193
Merged
Tobias-Fischer merged 1 commit intoNov 8, 2026
Conversation
Most callers (recipes, sources, the build-script template) pass the ROS name, which get_pkg_additional_info normalized again: a name starting with ros2_/ros_ lost that prefix (ros2_pulse -> pulse), so its entry (build number, additional_cmake_args, dummy package) was silently ignored. Use the name as it is when it's a key, else strip the conda prefix as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_pkg_additional_infonormalizes the name it's given (stripsros2_,ros_<distro>_,ros_), but most callers already pass the ROS name:recipes.pyandsources.py(is_dummy_metapackage(shortname, …)) andtemplate.py(the build script'sadditional_cmake_args). A ROS name that starts withros2_orros_loses that prefix there (ros2_pulse→pulse), so itspkg_additional_info.yamlentry is silently ignored:additional_cmake_args, dummy packages, and the build number where a caller passes the ROS name.Found in RoboStack/robostack#190:
ros2_pulse: additional_cmake_args(if: osx) never reached the build script, while the same entry for other packages works.Now the name is used as it is when it is a key; otherwise it's normalized as before, so conda names (
ros2-ros2-pulse,ros-humble-ros2-pulse) keep working.test_utils.py:ros2_pulsefound by its ROS and both conda names (entry and build number),rtabmap_odomlikewise, a package without an entry. Without the fix, the ROS-name case fails; all vinca tests pass (333).pkg_additional_info.yamlfiles (shared and per distribution) have no entries forros2_*/ros_*packages, so this changes nothing there.🤖 Generated with Claude Code