Skip to content

Preserve native question drafts across thread navigation (CF-3) - #348

Merged
BunsDev merged 5 commits into
mainfrom
cf3-audit
Oct 21, 2026
Merged

BunsDev merged 5 commits into
mainfrom
cf3-audit

Conversation

@BunsDev

@BunsDev BunsDev commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Native question choices and text disappear when switching threads because the card unmounts. Keep pending drafts in window memory scoped to their thread and request, and clear them on resolution, withdrawal, thread removal or retirement. Secret drafts never enter persisted composer recovery.

Related to #276 and tracker #273; retains the landed request broker, native approval policies and disabled preview gate.

Validation: the navigation regression failed before the fix and all three question E2E tests pass after it. After merging current main with the landed keyboard race fix #352, root build, typecheck and unit tests pass (1,907 passed, 16 skipped). Full E2E passes: 373 desktop tests (6 skipped), including all eight keyboard-answer tests, and 7 site tests.

The first CI attempt could not acquire hosted macOS runners. The second passed iPhone and unit coverage but hit the known Jump to latest race (371 desktop passed, 3 skipped, 1 failed). Bringing in #352 fixes that dependency; CI must pass on the updated head before the protected merge queue lands it.

A real Codex 0.163.0 question was answered through the app with the opt-in default_mode_request_user_input flag, and the model confirmed Blue. Default-mode async questions use a distinct form and remain unsupported by this broker. Human keyboard-only/VoiceOver acceptance remains unclaimed. Results and limitations are in docs/reviews/2026-10-20-cf3-drafts.md.

Commits are signed with the user-approved SSH signing key registered on GitHub. No approval policy or preview-gate default changed.

CI passed on 1847e0c (375 desktop tests, 3 skipped; 7 site tests; iPhone passed). While it ran, #351/#353 landed and conflicted only with the status entry. Current main was merged, both entries retained, and the full local checks rerun successfully on the combined branch. The new head must pass CI and merge-queue validation.

@vercel

vercel Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modex Ready Ready Preview Oct 21, 2026 12:03am UTC

Request Review

@github-code-quality

github-code-quality Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage-agent

main b654734 cf3-audit 0b6d10f +/-
64% 64% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated October 21, 2026 00:28 UTC

@BunsDev
BunsDev added this pull request to the merge queue Oct 21, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 21, 2026
@BunsDev
BunsDev added this pull request to the merge queue Oct 21, 2026
Merged via the queue into main with commit 337e73b Oct 21, 2026
13 checks passed
@BunsDev
BunsDev deleted the cf3-audit branch October 21, 2026 02:03

This branch was successfully deployed

1 active deployment
Preview — 0b6d10f3 Deployed Oct 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant