Repository navigation
Remove Ovm/Ovm3 leftovers from core code - #14555
Open
DaanHoogland wants to merge 1 commit into
Open
DaanHoogland wants to merge 1 commit into
DaanHoogland wants to merge 1 commit into
Conversation
1 of 7 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## removeHyperv #14555 +/- ##
==================================================
- Coverage 20.86% 20.86% -0.01%
- Complexity 21913 21914 +1
==================================================
Files 6470 6470
Lines 589106 589062 -44
Branches 72228 72219 -9
==================================================
- Hits 122900 122879 -21
+ Misses 452869 452845 -24
- Partials 13337 13338 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 26.03% |
| Branch coverage | 20.31% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DaanHoogland
force-pushed
the
removeOvmLeftovers
branch
from
November 3, 2026 14:27
ae1fb44 to
24e830a
Compare
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #14554
Description
Second PR of the stack: removes the Ovm/Ovm3 leftovers from core code. The plugins have not been built since #11196 ("ovm deprecation"). Based on the Hyper-V removal PR; review only the last commit.
Behaviour / API changes
ovm3networklabel. Theovm3networklabelrequest parameter is@Deprecatedand ignored.router.template.ovm3,ovm.{public,private,guest}.network.device,ovm3.{public,private,guest,storage}.network.device,ovm3.heartbeat.timeoutandovm3.heartbeat.interval.schema-42300to2400.sqldeletes them.hypervisor.listdefault no longer containsOvm/Ovm3.LXCstays: an earlier version of this change dropped it by mistake.templateConfig.sh, thedownload-ovm-systemvm-templateprofile andpackage.sh.Deliberately kept:
HypervisorType.Ovm/Ovm3, for the same DB-compatibility reason asHyperv. Also kept: historic upgrade paths, and the remainingOvmbranches inVolumeOrchestrator,StorageManagerImpl,OCFS2ManagerImpl,SnapshotManagerImplandResourceManagerImpl(possible follow-ups).Types of changes
How Has This Been Tested?
Unit tests updated:
ApiResponseHelperTest,SystemVmTemplateRegistrationTest,ManagementServerImplTest.🤖 Generated with Claude Code